Re: String freeze break in Gnome-Control-Center

[Jody Goldberg <jody gnome org>]

On Fri, Sep 03, 2004 at 11:52:56PM +0200, Christian Rose wrote:
> fre 2004-09-03 klockan 16.18 skrev Danilo ?egan:
> > Hi Jody, translators,
> > 
> > There's a string freeze break in g-c-c, though it seems
> > unintentional. It affects only one translated message.
> > 
> > CVS log entry[1] was:
> > 
> > 2004-07-23  Jody Goldberg <jody gnome org>
> > 
> > 	http://bugzilla.gnome.org/show_bug.cgi?id=148291
> > 	* configure.in : typo
> > 
> > 2004-06-07  Jody Goldberg <jody gnome org>
> > 
> > 	* po/POTFILES.in : add server file, still unused without the patch
> > 	* configure.in : ditto.
> > 
> > 2004-06-01  Jody Goldberg <jody gnome org>
> > 
> > 	* schemas/desktop_gnome_peripherals_keyboard_xkb.schemas.in : Add
> > 	  xkb/update_handlers.
> > 
> > Which indicates that this was supposed to be checked-in long time ago.
> > 
> > Unfortunately, this was checked in on Aug 28th, and I don't remember
> > any approval for this (FWIW, there's no ChangeLog entry at all for
> > this change, which is strange). 
> > 
> > The entire change is at [2].
> > 
> > Jody, Christian, can we have this discussed?
> > 
> > [1] http://cvs.gnome.org/viewcvs/gnome-control-center/gnome-settings-daemon/gnome-settings-keyboard-xkb.c?rev=1.14&view=log
> > [2] http://cvs.gnome.org/viewcvs/gnome-control-center/gnome-settings-daemon/gnome-settings-keyboard-xkb.c?r1=1.13&r2=1.14
> 
> This revert of a previous change broke current string freeze. Jody, can
> you please revert this change, alternatively give extremely good reasons
> why this change should go in now during string freeze and can't wait?

/me loses track of the reversions.

The change was not meant to go in and I reverted it this afternoon
when it was pointed out.  Are you asking me to unrevert it or keep
it reverted ?