Re: gconvert aliasing (bugzilla: #58195, #55152)

[Sven Neumann <sven gimp org>]

Hi,

HideToshi Tajima <hidetoshi.tajima@eng.sun.com> writes:

> Hi,
> 
> I tested glib's gconvert code change for charset aliasing, but it seems
> that there is a small typo which is required to fix when platform's native 
> iconv is in use.
> 
> Here is a one-line patch to fix the typo. Okay to check in?
> 
> Regards,
> HideToshi
> ------
> --- glib/gconvert.c     2001/10/01 20:40:05     1.23
> +++ glib/gconvert.c     2001/10/16 18:05:29
> @@ -111,7 +111,7 @@
>    if (!try_conversion (to_codeset, from_codeset, &cd))
>      {
>        const char **to_aliases = _g_charset_get_aliases (to_codeset);
> -      const char **from_aliases = _g_charset_get_aliases (to_codeset);
> +      const char **from_aliases = _g_charset_get_aliases (from_codeset);
>  
>        if (from_aliases)
>         {

the change looks correct, but you should definitely send it to
<gtk-devel-list@gnome.org> and get your OK to commit from the
GTK+/Glib developers.


Salut, Sven