Re: Enter the build sheriff: Jacob.

[Daniel Veillard <veillard redhat com>]

On Thu, Mar 14, 2002 at 10:48:00AM -0500, jacob berkman wrote:
> >   BUT, the build sheriff commited twice already without sending any mail
> > informing me of the potential problem.
> 
> i checked HACKING and it said:
> 
>      In the exceptional case where a serious breakage in this module
>     prevents other core projects from making progress, then feel free
>     to patch first and send mail afterward as long as the changes are
>     limited.
>     
> and in both cases this was true.

  Sorry, I didn't see the serious breakage, nor any complaint from 
other core projects maintainers that this may have been broken [1].
In both cases this was about python modules which may not have build in
some circumstances.  No core project relies on those modules. I don't see
either how this would have hampered the progresses of other modules. No
really ...
  This wording was there to allow really broken commits to get
reverted/fixed in case they were seriously blocking other projects.
  So I have 2 choices:
   1/ forget about it hoping that you will send mail first in the future
      in case the build break under some circumstances.
   2/ disallow commits from non-maintainers (4 persons in gnome-xml,
      3 persons in libxslt)

  I will do 1/ , 

Daniel

[1] actually James sent me a patch to apply to that part, I just didn't had
    the time to look at it.

P.S.: You know, I suck. Too bad, live with it, you know I want a mail before
      commits, it's not the first time, I hope it's the last.

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/