Patch to gnome-common.



The following patch fixes the macro GNOME_COMPILE_WARNINGS when it is
used with a parameter (to set the default). I tried filing it in
bugzilla but could not find the right module it should go to. 

May i commit?

thanks,
Chema



? macros/gnome-macros.dep
Index: macros2/ChangeLog
===================================================================
RCS file: /cvs/gnome/gnome-common/macros2/ChangeLog,v
retrieving revision 1.33
diff -u -5 -r1.33 ChangeLog
--- macros2/ChangeLog	1 Apr 2002 23:11:04 -0000	1.33
+++ macros2/ChangeLog	10 May 2002 03:17:01 -0000
@@ -1,5 +1,11 @@
+2002-05-09  Chema Celorio  <chema celorio com>
+
+	* compiler-flags.m4: GNOME_COMPILE_WARNINGS(maximum) was not working because
+	the last two arguments to AC_ARG_ENABLE where swaped, the default was $defaultval
+	which was never defined. 
+
 2002-04-01  jacob berkman  <jacob ximian com>
 
 	* gnome-x-checks.m4 (GNOME2_X_CHECKS): kill bogus clearing of
 	LDFLAGS
 
Index: macros2/compiler-flags.m4
===================================================================
RCS file: /cvs/gnome/gnome-common/macros2/compiler-flags.m4,v
retrieving revision 1.2
diff -u -5 -r1.2 compiler-flags.m4
--- macros2/compiler-flags.m4	1 Dec 2000 12:52:04 -0000	1.2
+++ macros2/compiler-flags.m4	10 May 2002 03:17:01 -0000
@@ -11,11 +11,11 @@
     else
 	default_compile_warnings="$1"
     fi
 
     AC_ARG_ENABLE(compile-warnings, 
-    [  --enable-compile-warnings=[no/minimum/yes/maximum/error]	Turn on compiler warnings.], [enable_compile_warnings="$enableval"],[enable_compile_warnings="$default_compile_warnings"])
+    [  --enable-compile-warnings=[no/minimum/yes/maximum/error]	Turn on compiler warnings.], [enable_compile_warnings="$default_compile_warnings"], enable_compile_warnings=yes)
 
     warnCFLAGS=
     if test "x$GCC" != xyes; then
 	enable_compile_warnings=no
     fi


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]