Re: patch for gnome-libs/libgnome (include of gnome-defs.h in files using BEGIN_GNOME_DECLS)
- From: Chema Celorio <chema ximian com>
- To: Havoc Pennington <hp redhat com>
- Cc: Miguel de Icaza <miguel ximian com>, Not Zed <NotZed ximian com>, James Henstridge <james daa com au>, Mikael Hallendal <micke hallendal net>, gnome-hackers gnome org, gnome-devel-list gnome org
- Subject: Re: patch for gnome-libs/libgnome (include of gnome-defs.h in files using BEGIN_GNOME_DECLS)
- Date: Wed, 28 Feb 2001 23:22:45 -0600
Havoc Pennington wrote:
>
> Miguel de Icaza <miguel ximian com> writes:
> > > > You have totally got to be kidding. Including gnome.h is a royal PITA
> > > > and blows out compile times something chronic.
> > > >
> > >
> > > Agreed, but including the individual headers doesn't work properly and
> > > was never tested before we released.
> >
> > I usually include the individual headers, and I do include
> > gnome-defs.h manually before they are used.
> >
> > I dont think this patch will cause any major problems.
>
> I'm simply explaining why James said including them individually isn't
> supported; because it's been broken for 2 years.
Do we _NEED_ to include this patch at this point ?
I don't think we should. I can see scenarios that this can cause
problems. If as a developer I code on the gnome-libs with the
patch that includes the other headers for me, my app might not
compile in a previous version of g-libs that didn't included
headers for me.
Yes it is broken but I don't think this is the time to fix it.
Chema
>
> Havoc
>
> _______________________________________________
> gnome-hackers mailing list
> gnome-hackers gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-hackers
_______________________________________________
gnome-hackers mailing list
gnome-hackers gnome org
http://mail.gnome.org/mailman/listinfo/gnome-hackers
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]