Re: gtk+ entry patch

[Ghee Seng Teo <Ghee Teo ireland sun com>]

Hi All,
	
	As I am fairly new to Gnome and GTK+,
	Justin's fix brought to me to ask these questions:
	- What if the user a two button mouse? 
	- What happen to the GTK+ port on the Mac (is there one) running Linux
	which traditionally has only one button?
	
	I don't propose that I can provide an alternative right now. I do
	like to have some views on the above from the GTK+ gurus.
	
	Another comment (without a great deal knowledge about GTK+) is
	on 
	+      else if (event->button == 3)
	+        {
			menu = gtk_menu_new ();
		
	A new menu is created when everytime the user clicks on button3,
	these could leak memory. should it not be a like,
		if (!menu)
		{
		 /* same bit of code except the bits below */
		}
		
		gtk_widget_show (cut_item);
		gtk_widget_show (copy_item);
		gtk_widget_show (paste_item);
		gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL, 3, 
		  event->time); 


Ghee Teo
e-mail: Ghee Teo ireland sun com


	
>  Delivered-To: gnome-hackers-readonly gnome org
>  Delivered-To: gnome-hackers gnome org
>  From: Justin Maurer <justin helixcode com>
>  MIME-Version: 1.0
>  Content-Transfer-Encoding: 7bit
>  Date: Thu, 14 Dec 2000 18:12:12 -0500 (EST)
>  To: gnome-hackers gnome org
>  Subject: gtk+ entry patch
>  X-BeenThere: gnome-hackers gnome org
>  X-Loop: gnome-hackers gnome org
>  X-Mailman-Version: 2.0beta5
>  List-Id: <gnome-hackers.gnome.org>
>  X-BeenThere: gnome-hackers-readonly gnome org
>  X-Loop: gnome-hackers-readonly gnome org
>  
>  
>  hey guys,
>  
>      miguel asked me to write a patch to have gtk+ entries give popup
>  menus for cut/copy/paste when a user right-clicks them (apparently,
>  this is in gtk+ 2.0). i have attached the patch against gtk+ 1.2; i
>  hope you find it useful. the only thing obviously wrong to me is the
>  fact that cut/copy/paste_cb() don't really fit the function naming
>  schema :) this patch works for me, and afaik, does not break binary
>  compatibility.
>  
>  best wishes,
>  justin
>  



_______________________________________________
gnome-hackers mailing list
gnome-hackers gnome org
http://mail.gnome.org/mailman/listinfo/gnome-hackers