Re: [gnome-flashback] [RFC 0/1] input-sources: Assign groups in order while setting user layouts

[Ignacy Gawędzki <bugs qult net>]

On Thu, Nov 16, 2017 at 06:06:40PM +0200, thus spake Alberts Muktupāvels:
>    Hi,
>
>    please open bug (and attach patch) here:
>    [1]https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-flashback

Hi,

So I did that shortly after, and the report obviously went unnoticed,
since the patch hasn't been applied for that many months.

FWIW, I've stumbled upon another bug today, fixed it and opened
another bug report with the attached patch:

  https://bugzilla.gnome.org/show_bug.cgi?id=796148

It would be really nice if someone could review these two.

Cheers,

Ignacy

>    On Thu, Nov 16, 2017 at 1:39 AM, Ignacy Gawędzki <[2]bugs qult net> wrote:
>
>      Hi,
>
>      I recently noticed that when I configure both fr and us layouts for my
>      keyboard, the fr always ends up in group 1, no matter in what order
>      the layouts are configured.  This went unnoticed for a long time until
>      I figured that SDL-based software always assumed that my keyboard is
>      in the fr layout while it clearly wasn't.  It seems that SDL always
>      considers Group 1's layout no matter what.
>
>      I traced the source of the problem in
>      libinput-sources/gf-keyboard-manager.c, which doesn't honor the order
>      of the configured layouts when assigning groups, because it does so
>      *after* having inserted the layout info into the hash table.  I tested
>      the patch that follows and not only does it simplify the setting of
>      the layouts (no additional iteration on the hash table elements), but
>      it also solves my initial problem.
>
>      Cheers,
>
>      Ignacy
>
>      Ignacy Gawędzki (1):
>        input-sources: Assign groups in order while setting user layouts
>
>       .../libinput-sources/gf-keyboard-manager.c         | 58
>      +++++++++-------------
>       1 file changed, 24 insertions(+), 34 deletions(-)
>      --
>      2.14.1
>      _______________________________________________
>      gnome-flashback-list mailing list
>      [3]gnome-flashback-list gnome org
>      [4]https://mail.gnome.org/mailman/listinfo/gnome-flashback-list
>
>    --
>    Alberts Muktupāvels
>
> References
>
>    Visible links
>    1. https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-flashback
>    2. mailto:bugs qult net
>    3. mailto:gnome-flashback-list gnome org
>    4. https://mail.gnome.org/mailman/listinfo/gnome-flashback-list

-- 
Everything is more fun naked except cooking with grease.