[gnome-flashback] [RFC 0/1] input-sources: Assign groups in order while setting user layouts



Hi,

I recently noticed that when I configure both fr and us layouts for my
keyboard, the fr always ends up in group 1, no matter in what order
the layouts are configured.  This went unnoticed for a long time until
I figured that SDL-based software always assumed that my keyboard is
in the fr layout while it clearly wasn't.  It seems that SDL always
considers Group 1's layout no matter what.

I traced the source of the problem in
libinput-sources/gf-keyboard-manager.c, which doesn't honor the order
of the configured layouts when assigning groups, because it does so
*after* having inserted the layout info into the hash table.  I tested
the patch that follows and not only does it simplify the setting of
the layouts (no additional iteration on the hash table elements), but
it also solves my initial problem.

Cheers,

Ignacy

Ignacy Gawędzki (1):
  input-sources: Assign groups in order while setting user layouts

 .../libinput-sources/gf-keyboard-manager.c         | 58 +++++++++-------------
 1 file changed, 24 insertions(+), 34 deletions(-)

-- 
2.14.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]