Hi! I think this should go in master and 3.8 branches. I am working and testing this with gtk 3.8.2. What is point of having 3.8 if it is almost same as 3.6? If we don't use these patches here (in 3.8 branch) than I would say we should rename it 3.8 to 3.6.3. It would make more sense. 1) Removed GTK version check. We will just use non deprecated function. Removed deprecated gdk_threads_enter and gdk_threads_leave functions. Do they really is needed now? For example. Why function gdk_x11_set_sm_client_id was between gdk_threads_[enter/leave] functions? I don't see any need for it. 2) Bumped required gtk version to 3.8 3) Fixed typo in libpanel-applet-private Makefile.am 4) Fixed deprecated warnings in notification_area/testtray.c. 5) panel-ditem-editor.c: replaced GtkTable with GtkGrid. Works same way as it worked before this fix. 6) Don't set panel initial size to G_MAXINT. It is not needed! 7) panel-toplevel.c: replaced GtkTable with GtkGrid. Panels works same way as it worked before change. Panel size change or expand/unexpand does not work. But it was broken before this change. 8) Fixed panel properties. With this patch now is possible to change panel size, make panel expand/unexpand. Show/Hide hide buttons work good when panel is expanded or unexpanded. Moving horizontal panel to became vertical panel works. Definitely this is improvement! It would be nice if someone could test this and report if this does not break anything. No one can reply me on previous questions? Currently I am interested to get reply about panel-bindings.c as I don't like to see errors and warnings. We need do something about it. -- Alberts Muktupāvels
Attachment:
gnome-panel-patches.zip
Description: Zip archive