|
Hi Everyone, I have been looking abit through the list of patches currently unreviewed for gnome-panel: https://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=gnome-panel&patch-status=none There are currently about 120 patches in Bugzilla that are unreviewed. I think we should try to go through all of them and see if we can either can close some of them right away by either commiting the patch or rejecting it. If neither is possible we should try to make a comment what needs to be done. I have already started to review a few bugs: Bug 660517 - gnome-panel fails to build because of underlinking Marked as: RESOLVED OBSOLETE Bug 586983 - remove scrolling I have marked the patch as rejected. We can either close the bug and leave it as is or decide if we want to write a patch Bug 598196 - new feature - disable/enable ugly arrow in menu button This patch was written for GConf, its probably not too much work to change it to GSettings Bug 417853 - Lockdown: Remove Places from menu bar This patch was also written for GConf, and its probably also not much work to change it to GSettings Bug 614572 - Main menu opens towards middle of X screen in stead of middle of monitor I have uploaded a revised patch. I think we should commit for now. It looks logical and does not apparently break anything. We will still have enough time to collect feedback from users and revert it before 3.10 if it breaks anything. Bug 695807 - [PATCH] Calendar window doesn't remember location expander state This is probably an easy one to close. Unfortunately I cannot verify it at the moment because the clock applet won't add itself to my panels. Bug 709660 - panel-menu-items.c: Split into multiple files I have created a rather huge patch to split this file into three files. I think that will make it easier clean up files in the future. I would like to have some feedback if these kind of patches are welcome and if so, what still needs to be done. Generally I think its not good to have files with several thousand lines of code and spliting them up improves cohesion and allows us to find coupling issues more easy. Bug 578487 - please choose another separator than '/' between wind direction and velocity This is another easy one. We just have to decide if we want to commit this patch or not. It seems reasonable so I suggest to just commit it. Besides these old patches I would like to see some comments on Alberts and my patches. I think thats enough for today. I will review some more patches when I have answers to this mail. P.S. I have also given permissions for gnome-panel to Alberts, so he has better control over the bugs. Since he has been very active answering my bug reports so far. Regards Sebastian |