Re: [gnome-flashback] Patch to remove libegg (EggSMClient)

[Alberts Muktupāvels <alberts muktupavels gmail com>]

Hi Philipp!

I asked you repeatedly to file bugs for these kind of patches !

Ok, I created new bug reports and attached to them. Is it ok now?

And if you send them to the list for discussing a specific thing,
_please_ don't send them zipped, or worse, rar'ed. Rar is a non-free
format and either way, you don't even give us a chance to hit reply and
compose specific criticisms. Plus, there was a zip file with 8 patches
recently, and I have no idea which of these are new, which of them I
have already reviewed, and which ones you updated in response to a review.

I created archives for patch because mailing list does allow only 40 kb mails. Without approve no one will see them. You can ignore patches sent to mailing list. I created bug reports for almost all patches.

We also have EggDesktopFile. Could you write a few lines how we use this
and what is the recommended replacement ?

Created new patch which does not remove EggDesktopFile, but seems that it is safe to remove it too. We are using it only to set application name and icon.

--
Alberts Muktupāvels

On Sun, Oct 6, 2013 at 1:51 AM, Philipp Kaluza <floss ghostroute eu> wrote:

Hi Alberts !

Am 05.10.2013 20:43, schrieb Alberts Muktupāvels:

> Hi All!
>
> Attached patch which removes libegg (EggSMClient).

I asked you repeatedly to file bugs for these kind of patches !

And if you send them to the list for discussing a specific thing,
_please_ don't send them zipped, or worse, rar'ed. Rar is a non-free
format and either way, you don't even give us a chance to hit reply and
compose specific criticisms. Plus, there was a zip file with 8 patches
recently, and I have no idea which of these are new, which of them I
have already reviewed, and which ones you updated in response to a review.

I had planned to allocate half of Sunday for patch review, but at the
moment I'm just annoyed.

If somebody is willing to set up and maintain a Gerrit installation for
gnome, we can switch to that, but until now we're stuck with Bugzilla.

I guess it's my own fault for still reviewing and applying stuff you
send to the mailing list. Don't get me wrong, I'm happy that you are so
active. But you need to give everybody else a real chance to study your
work before it vanishes beneath the mailing list's S/N threshold.

@Everybody: feel free to also review patches. :-)


@Lanoxx and those that don't know libegg: it was a library of utility
code, nor built as a .so, but copy&pasted into different projects.

> * Last commit in git is almost year ago. (https://git.gnome.org/browse/libegg/)
> * It is not ported to gtk3. At least comment #37 says it needs to be
> done. (https://bugzilla.gnome.org/show_bug.cgi?id=79285)

Well, gnome-panel _is_ a GTK+ 3 app, so the part of libegg that we are
compiling and using works just fine. That said, EggSMClient is a no-op
under most any current gnome-session (and probably mate-session too -
mate guys ?). So this should be fine to rip out.

We also have EggDesktopFile. Could you write a few lines how we use this
and what is the recommended replacement ?

Cheers
  Philipp

--
Philipp Kaluza
Ghostroute IT Consulting