Re: Boxes: string breaks

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

On Mon, Sep 14, 2015 at 7:44 PM, Alexandre Franke
<alexandre franke gmail com> wrote:
> On Mon, Sep 14, 2015 at 8:31 PM, Zeeshan Ali (Khattak)
> <zeeshanak gnome org> wrote:
> > Hi,
>
> Hi,
>
> > Can I please please break a few strings to fix an annoying UI issue
> > before I roll out 3.17.92?
> >
> > https://bugzilla.gnome.org/show_bug.cgi?id=754419
> > https://bug754419.bugzilla-attachments.gnome.org/attachment.cgi?id=311308
>
> Given how late it is now,

I asked as soon as I had the patch and not long after I knew how I'm
going to solve this in the end (i-e when I knew how strings will be
effected).

> and more importantly how you didn't care to
> give us a list of strings

I provided a link to attachment. I would have done a better job if I
didn't realize this is coming in very late. Here is the diff showing
the changed strings:

--- /tmp/gnome-boxes.pot    2015-09-14 19:48:50.771966983 +0100
+++ gnome-boxes.pot    2015-09-14 19:49:00.513906844 +0100
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-09-14 19:48+0100\n"
+"POT-Creation-Date: 2015-09-14 19:49+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL ADDRESS>\n"
 "Language-Team: LANGUAGE <LL li org>\n"
@@ -432,6 +432,12 @@
 msgid "_Undo"
 msgstr ""

+#. Translators: First '%s' is name of box and second one is it's
status (e.g 'connecting...')
+#: ../src/app-window.vala:442
+#, c-format
+msgid "%s: %s"
+msgstr ""
+
 #: ../src/display-page.vala:110
 msgid "Press (left) Ctrl+Alt to ungrab"
 msgstr ""
@@ -636,16 +642,14 @@
 msgid "'%s' will be paused automatically to save resources."
 msgstr ""

-#. Translators: The %s will be expanded with the name of the vm
+#. Translators: Shown when restoring a box from a saved state
 #: ../src/libvirt-machine.vala:588
-#, c-format
-msgid "Restoring %s from disk"
+msgid "Restoring state…"
 msgstr ""

-#. Translators: The %s will be expanded with the name of the vm
+#. Translators: Shown when starting a box
 #: ../src/libvirt-machine.vala:591
-#, c-format
-msgid "Starting %s"
+msgid "Starting…"
 msgstr ""

 #: ../src/libvirt-machine.vala:656
@@ -731,39 +735,38 @@
 msgid "Powered Off"
 msgstr ""

-#. Translators: The %s will be expanded with the name of the vm
-#: ../src/machine.vala:195
-#, c-format
-msgid "Connecting to %s"
-msgstr ""
-
-#: ../src/machine.vala:217 ../src/machine.vala:611
+#: ../src/machine.vala:214 ../src/machine.vala:610
 #, c-format
 msgid "Connection to '%s' failed"
 msgstr ""

-#: ../src/machine.vala:412
+#: ../src/machine.vala:409
 msgid "Saving…"
 msgstr ""

-#: ../src/machine.vala:597
+#. Translators: This is shown when connecting to a box
+#: ../src/machine.vala:571
+msgid "Connecting…"
+msgstr ""
+
+#: ../src/machine.vala:596
 #, c-format
 msgid ""
 "'%s' could not be restored from disk\n"
 "Try without saved state?"
 msgstr ""

-#: ../src/machine.vala:598
+#: ../src/machine.vala:597
 msgid "Restart"
 msgstr ""

-#: ../src/machine.vala:607
+#: ../src/machine.vala:606
 #, c-format
 msgid "Failed to start '%s'"
 msgstr ""

 #. Translators: %s => name of launched box
-#: ../src/machine.vala:640
+#: ../src/machine.vala:639
 #, c-format
 msgid "'%s' requires authentication"
 msgstr ""


> nor explain why we should grant you an
> exception,

Same reason and I see a few other issues I really should fix before
code freeze. You can find the rationale on the bug description:

"Unifying 'status' of machines caused some issues and the one that's
not yet resolved is us showing "Connecting to '%s'" and "Restoring
'%s'" in collection views, where it doesn't completely fit in the
available space usually and also it looks odd given that name of the
machine is already shown in the context and is clear to user.

We either need to modify these strings somehow or ensure that these
status messages don't get shown in collection views."

There are also screenshots there. Please let me know if anything is
not clear and I can try to explain.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/