Re: Request for UI freeze break



Thank you for the approvals. The patches have been pushed already...

Ondrej

----- Original Message -----
From: "Matthias Clasen" <matthias clasen gmail com>
To: "Andre Klapper" <ak-47 gmx net>
Cc: "Ondrej Holy" <oholy redhat com>, "GNOME release team" <release-team gnome org>, "gnome-doc-list" 
<gnome-doc-list gnome org>
Sent: Thursday, September 4, 2014 5:58:54 PM
Subject: Re: Request for UI freeze break

On Thu, Sep 4, 2014 at 11:18 AM, Andre Klapper <ak-47 gmx net> wrote:
On Thu, 2014-09-04 at 10:41 -0400, Ondrej Holy wrote:
I'd like to request UI freeze break for the Gnome Control Center to fix wrong padding in the User accounts 
panel. Patches are attached in the Bug 736009:
https://bugzilla.gnome.org/show_bug.cgi?id=736009

The UI change is shown in a screenshot:
https://bug736009.bugzilla-attachments.gnome.org/attachment.cgi?id=285311

Looks good to me (r-t approval 1 of 2).


Second approval for the release team.

The patches are not quite perfect, since you only query the style
context once for the padding values when the page is setup. For extra
credit, you should redo that when the theme changes. But since you got
the a-c-n in bugzilla already...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]