Re: gnome-user-docs Patch Reviews

[Phil Bull <philbull gmail com>]

Hi Paul,

On Sun, 2009-04-05 at 20:15 -0500, Paul Cutler wrote:
[...]
> These patches I submitted and they need a peer review:

I submitted some comments on the bugs themselves.

> I need help with these two bugs, I think I can fix them with some clarification:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=380075 : Rotation setting in
> Screen Resolution capplet.
> 
> Currently the documentation says:  "Select the rotation for the
> currently selected monitor.  This option may not be supported on all
> graphics cards.".
> 
> The submitted patch changes it to:  "This option may not be available
> on your system. It relies on the video card supporting the
> RandRRotation option, which must first be set in the X configuration
> file."
> 
> I think the first one, from a user experience, makes more sense.  If
> so, the bug can be closed.

I agree, the proposed patch is too technical and the bug should be
closed. It might make sense to clarify the existing wording though,
maybe to something like "Select the way that the screen is rotated for
the currently selected monitor". What do you think?

> http://bugzilla.gnome.org/show_bug.cgi?id=571393 : Remove
> network-admin - Need to make sure there are no links to this from
> network-admin or network-admin docs
> 
> Where are network-admin and network-admin docs? - Any pointers are
> appreciated, I'll check those files to make sure there aren't any
> links.  I looked in Bugzilla, but didn't see those as components.

network-admin is part of gnome-system-tools. You can find the
network-admin docs here [1].

Thanks for all of your hard work,

Phil

[1] -
http://svn.gnome.org/viewvc/gnome-system-tools/trunk/doc/network/C/

-- 
Phil Bull
https://launchpad.net/people/philbull