[PATCH 00/14] Code cleanups

[Rupert Swarbrick <rswarbrick gmail com>]

These patches fix all the warnings from gcc with -Wall and (the
meaningful ones) from cppcheck in the libyelp directory. (Except for
yelp-man-parser, but I've posted a separate patchset which deals with
that).

Frankly, you may not wish to apply fourteen teensy patches. So I've
bundled the lot together into one larger patch which I'm also sending
to the list - use either!

Rupert Swarbrick (14):
  Fix missing return value.
  Unused variable.
  Fix missing return values and typecast.
  Missing return values.
  Add typecasts and a header we use.
  Unused variable.
  Remove unused variables.
  Lots of typecasts and some unused variables.
  Missing return values.
  Unused variables.
  Unused variable.
  Remove unused variables and undefined functions!
  Fix missing return type and incorrect test (= not ==).
  Fix memory leaks found by cppcheck.

 libyelp/yelp-bookmarks.c        |    2 +-
 libyelp/yelp-bz2-decompressor.c |    1 -
 libyelp/yelp-docbook-document.c |    6 +++-
 libyelp/yelp-document.c         |   13 ++++++----
 libyelp/yelp-document.h         |    2 +-
 libyelp/yelp-help-list.c        |   26 ++++++++++++++-------
 libyelp/yelp-info-parser.c      |    2 +-
 libyelp/yelp-location-entry.c   |   19 ++++++---------
 libyelp/yelp-mallard-document.c |   47 ++++++++++++++++++++------------------
 libyelp/yelp-man-document.c     |    4 ++-
 libyelp/yelp-settings.c         |    7 +++--
 libyelp/yelp-simple-document.c  |    2 -
 libyelp/yelp-transform.c        |    4 ---
 libyelp/yelp-view.c             |    6 ++--
 14 files changed, 75 insertions(+), 66 deletions(-)

-- 
1.7.2.3