Dear maintainers, While intensively using 'gedit' editing lots of intricate bash shell scripts, it came to need fixing a few issues originating from 'gtksourceview' own shell language spec file -- sh.lang: * shell function names might well (and in fact very often do) contain the minus char: ASCII 0x2d, '-'; * the spec file does not handle the command substitutions of form '$(...)'; * the rendering of 'case' statement fails quite badly when the pattern of a case and its corresponding command containing a closing paren do lie on the same line. In this latter case, the entire code segment -- from the beginning of the case pattern all the way to the closing paren and including a portion of the command itself -- is rendered as if it belongs to the case pattern. Worse than that is when the respective command portion do contain a quoting char, causing potentially significant subsequent segments of code being unpleasantly rendered as of belonging to a quoted string. The two PNG files attached illustrate each of the things described. Fortunately, these issues can easily be fixed (at least so it seems). Please look upon the patch file attached. Sincerely, Stefan Vargyas.
Attachment:
gtksourceview-3.12.1-sh-lang.patch
Description: Text document
Attachment:
test.sh
Description: application/shellscript
Attachment:
test-sh-before-patching.png
Description: PNG image
Attachment:
test-sh-after-patching.png
Description: PNG image
