Created attachment 311031 [details] [review] Patch to improve intropectable API for GdaNumeric This patch remove public API from GdaNumeric. Seems not problem on compilation but make check fails for reasons not related to this patch, but should be patched before continue to apply this patch in order to verify it doesn't break any thing. Output of make check: $ make check Making check in po make[1]: Entering directory '/home/despinosa/Proyectos/libgda/po' INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" srcdir=. /usr/bin/intltool-update --gettext-package libgda-6.0 --pot rm -f missing notexist srcdir=. /usr/bin/intltool-update -m if [ -r missing -o -r notexist ]; then \ exit 1; \ fi make[1]: Leaving directory '/home/despinosa/Proyectos/libgda/po' Making check in libgda make[1]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' Making check in sqlite make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make check-recursive make[3]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' Making check in sqlite-src make[4]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/sqlite-src' make[4]: Nothing to be done for 'check'. make[4]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/sqlite-src' Making check in virtual make[4]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/virtual' CC gda-vconnection-data-model.lo CC gda-vconnection-hub.lo CC gda-vprovider-data-model.lo CC gda-vprovider-hub.lo CC gda-virtual-connection.lo CC gda-virtual-provider.lo CCLD libgda-virtual-6.0.la make[4]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/virtual' make[4]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' CC libgda_sqlite_la-gda-sqlite-blob-op.lo CC libgda_sqlite_la-gda-sqlite-ddl.lo CC libgda_sqlite_la-gda-sqlite-handler-bin.lo CC libgda_sqlite_la-gda-sqlite-handler-boolean.lo CC libgda_sqlite_la-gda-sqlite-meta.lo CC libgda_sqlite_la-gda-sqlite-provider.lo In file included from gda-sqlite-provider.c:49:0: gda-sqlite-provider.c: In function 'gda_sqlite_provider_prepare_connection': gda-sqlite.h:50:31: warning: the address of 'sqlite3_enable_load_extension' will always evaluate as 'true' [-Waddress] #define SQLITE3_CALL(x) (x) ^ gda-sqlite-provider.c:907:7: note: in expansion of macro 'SQLITE3_CALL' if (SQLITE3_CALL (sqlite3_enable_load_extension)) ^ CC libgda_sqlite_la-gda-sqlite-pstmt.lo CC libgda_sqlite_la-gda-sqlite-recordset.lo CC libgda_sqlite_la-gda-sqlite-util.lo CC libgda_sqlite_la-gda-symbols-util.lo CCLD libgda-sqlite.la CC libgda_sqlcipher_la-gda-sqlite-blob-op.lo CC libgda_sqlcipher_la-gda-sqlite-ddl.lo CC libgda_sqlcipher_la-gda-sqlite-handler-bin.lo CC libgda_sqlcipher_la-gda-sqlite-handler-boolean.lo CC libgda_sqlcipher_la-gda-sqlite-meta.lo CC libgda_sqlcipher_la-gda-sqlite-provider.lo gda-sqlite-provider.c: In function 'gda_sqlite_provider_open_connection': gda-sqlite-provider.c:867:32: warning: the address of 'sqlite3_key' will always evaluate as 'true' [-Waddress] if (passphrase && *passphrase && SQLITE3_CALL (sqlite3_key)) { ^ In file included from gda-sqlite-provider.c:49:0: gda-sqlite-provider.c: In function 'gda_sqlite_provider_prepare_connection': gda-sqlite.h:39:29: warning: the address of 'sqlite3_enable_load_extension' will always evaluate as 'true' [-Waddress] #define SQLITE3_CALL(x) (x) ^ gda-sqlite-provider.c:907:7: note: in expansion of macro 'SQLITE3_CALL' if (SQLITE3_CALL (sqlite3_enable_load_extension)) ^ gda-sqlite-provider.c: In function 'gda_sqlite_provider_perform_operation': gda-sqlite-provider.c:1331:35: warning: the address of 'sqlite3_key' will always evaluate as 'true' [-Waddress] *g_value_get_string (value) && ^ CC libgda_sqlcipher_la-gda-sqlite-pstmt.lo CC libgda_sqlcipher_la-gda-sqlite-recordset.lo CC libgda_sqlcipher_la-gda-sqlite-util.lo CC libgda_sqlcipher_la-gda-symbols-util.lo CCLD libgda-sqlcipher.la make[4]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make[3]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' Making check in handlers make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/handlers' CC gda-handler-bin.lo CC gda-handler-boolean.lo CC gda-handler-numerical.lo CC gda-handler-string.lo CC gda-handler-time.lo CC gda-handler-type.lo CCLD libgda_handlers-6.0.la make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/handlers' Making check in binreloc make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/binreloc' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/binreloc' Making check in sql-parser make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sql-parser' CC gda-sql-parser-enum-types.lo CC parser.lo CC delimiter.lo CC gda-sql-parser.lo CC gda-statement-struct.lo CC gda-statement-struct-compound.lo CC gda-statement-struct-delete.lo CC gda-statement-struct-update.lo CC gda-statement-struct-insert.lo CC gda-statement-struct-parts.lo CC gda-statement-struct-pspec.lo CC gda-statement-struct-select.lo CC gda-statement-struct-trans.lo CC gda-statement-struct-unknown.lo CC gda-statement-struct-util.lo CCLD libgda_sql_parser-6.0.la make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sql-parser' Making check in providers-support make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/providers-support' CC gda-pstmt.lo CCLD libgda-psupport.la make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/providers-support' Making check in thread-wrapper make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make test-raw-itsignaler test-itsignaler test-blocking-itsignaler test-worker test-connect test-raw-itsignaler-no-eventfd make[3]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[3]: 'test-raw-itsignaler' is up to date. make[3]: 'test-itsignaler' is up to date. make[3]: 'test-blocking-itsignaler' is up to date. make[3]: 'test-worker' is up to date. make[3]: 'test-connect' is up to date. make[3]: 'test-raw-itsignaler-no-eventfd' is up to date. make[3]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make check-TESTS make[3]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[4]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' PASS: test-raw-itsignaler PASS: test-itsignaler PASS: test-blocking-itsignaler PASS: test-worker PASS: test-connect PASS: test-raw-itsignaler-no-eventfd make[5]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[5]: Nothing to be done for 'all'. make[5]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' ============================================================================ Testsuite summary for GNU Data Access 5.99.0 ============================================================================ # TOTAL: 6 # PASS: 6 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ make[4]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[3]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[2]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' CC dir-blob-op.lo CC gda-attributes-manager.lo CC gda-data-meta-wrapper.lo CC gda-data-model-dsn-list.lo CC gda-enum-types.lo CC gda-batch.lo CC gda-blob-op.lo CC gda-column.lo CC gda-config.lo CC gda-connection.lo CC gda-data-comparator.lo CC gda-data-handler.lo CC gda-data-model-array.lo CC gda-data-model.lo CC gda-data-model-dir.lo CC gda-data-model-import.lo CC gda-data-model-iter.lo CC gda-data-access-wrapper.lo CC gda-data-proxy.lo CC gda-data-select.lo CC gda-holder.lo CC gda-init.lo CC gda-meta-store.lo CC gda-meta-struct.lo CC gda-meta-struct-io.lo CC gda-quark-list.lo CC gda-repetitive-statement.lo CC gda-row.lo CC gda-set.lo CC gda-server-operation.lo gda-server-operation.c: In function 'gda_server_operation_is_valid_from_resource': gda-server-operation.c:2572:10: warning: unused variable 'list' [-Wunused-variable] GSList *list; ^ CC gda-server-provider.lo CC gda-server-provider-extra.lo CC gda-statement.lo CC gda-sql-builder.lo CC gda-tree-mgr-columns.lo CC gda-tree-mgr-schemas.lo CC gda-tree-mgr-tables.lo CC gda-tree-node.lo CC gda-tree-manager.lo CC gda-tree-mgr-label.lo CC gda-tree-mgr-select.lo CC gda-util.lo CC gda-value.lo CC gda-xa-transaction.lo CC gda-data-pivot.lo CCLD libgda-6.0.la GISCAN Gda-6.0.gir ** (process:24017): WARNING **: Missing or malformed file '/usr/local/share/libgda-6.0/information_schema.xml', check your installation 'Class' object has no attribute 'get_parameter' <unknown>:: Warning: Gda: (Signal)status-changed: context=Signal('status-changed') argument status: Unresolved type: 'GdaConnectionStatus' GICOMP Gda-6.0.gir make test-cnc-open test-cnc-exec test-cnc-meta make[3]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' CC test-cnc-open.o CCLD test-cnc-open CC test_cnc_exec-test-cnc-exec.o CCLD test-cnc-exec CC test_cnc_meta-test-cnc-meta.o CCLD test-cnc-meta make[3]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' make check-TESTS make[3]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' make[4]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' PASS: test-cnc-open PASS: test-cnc-exec FAIL: test-cnc-meta make[5]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' Making all in sqlite make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make all-recursive make[7]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' Making all in sqlite-src make[8]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/sqlite-src' make[8]: Nothing to be done for 'all'. make[8]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/sqlite-src' Making all in virtual make[8]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/virtual' make[8]: Nothing to be done for 'all'. make[8]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite/virtual' make[8]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make[8]: Nothing to be done for 'all-am'. make[8]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make[7]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sqlite' Making all in handlers make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/handlers' make[6]: Nothing to be done for 'all'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/handlers' Making all in binreloc make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/binreloc' make[6]: Nothing to be done for 'all'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/binreloc' Making all in sql-parser make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/sql-parser' make[6]: Nothing to be done for 'all'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/sql-parser' Making all in providers-support make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/providers-support' make[6]: Nothing to be done for 'all'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/providers-support' Making all in thread-wrapper make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[6]: Nothing to be done for 'all'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda/thread-wrapper' make[6]: Entering directory '/home/despinosa/Proyectos/libgda/libgda' make[6]: Nothing to be done for 'all-am'. make[6]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' make[5]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' ============================================================================ Testsuite summary for GNU Data Access 5.99.0 ============================================================================ # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See libgda/test-suite.log Please report to https://bugzilla.gnome.org/enter_bug.cgi?product=libgda ============================================================================ Makefile:1600: recipe for target 'test-suite.log' failed make[4]: *** [test-suite.log] Error 1 make[4]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' Makefile:1706: recipe for target 'check-TESTS' failed make[3]: *** [check-TESTS] Error 2 make[3]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' Makefile:1821: recipe for target 'check-am' failed make[2]: *** [check-am] Error 2 make[2]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' Makefile:1493: recipe for target 'check-recursive' failed make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory '/home/despinosa/Proyectos/libgda/libgda' Makefile:736: recipe for target 'check-recursive' failed make: *** [check-recursive] Error 1