Re: [gnome-db] API break: GdaSqlErrorType->GdaSqlError

[Murray Cumming <murrayc murrayc com>]

On Tue, 2010-03-23 at 16:12 -0600, Daniel Espinosa wrote:
> I think we've missed generated *_get_type() function, at the end of
> the patch you can find a typedef for GdaSqlErrorType in order to avoid
> API  break, but may be a
> 
> #define gda_sql_error_type_get_type (gda_sql_error_get_type)
> 
> can be used in order to avoid API/ABI break, hope not to have a
> mistake about the functions' names, if so I'll investigate about it
> and will send a patch for it.
> 
> We don't want  API/ABI break for 4.0 series.

Thanks, but that would only fix API, not ABI.

It would need to be an actual function. Otherwise you are removing a
function from the library, causing a linker error when previously-linked
applications try to use it.

> 2010/3/23 Murray Cumming <murrayc murrayc com>:
> > This commit breaks API and ABI by changing an enum type name (and
> > therefore also changing the generated *_get_type() function name).
> > http://git.gnome.org/browse/libgda/commit/?id=cf068a1eb3611eea89014514fcfec1267f74d2b0
> >
> > libgdamm is probably the only one affected by this, and we have fixed
> > our build, but you should be aware of it.
> >
> >
> > Incidentally, it is yet another example of mistakes creeping in when
> > people don't bother to review their code when writing real ChangeLog
> > entries.
> >
> > --
> > murrayc murrayc com
> > www.murrayc.com
> > www.openismus.com
> >
> > _______________________________________________
> > gnome-db-list mailing list
> > gnome-db-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-db-list
> >
> 
> 
> 


-- 
murrayc murrayc com
www.murrayc.com
www.openismus.com