Re: [gnome-db] ODBC provider on MinGW/MSYS

["Yaakov (Cygwin Ports)" <yselkowitz users sourceforge net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Brecht Sanders wrote:
> I recently suggested adding something like
>     #ifdef G_OS_WIN32
>       #define strtok_r(s,d,p) strtok(s,d)
>     #endif
> to libgda/gda-decl.h.
> Should this also be G_PLATFORM_WIN32 instead?

NO!

> Or does Cygwin have strtok_r and should the ifdef only apply to MinGW?

Yes.

Here's a hint: if MinGW needs the same fix as Cygwin already has, then
use G_PLATFORM_WIN32.  If you need a fix for something that I didn't
fix, then it's MinGW specific (like strtok_r) and use G_OS_WIN32.

You will want to make sure that MinGW's strtok actually *runs* properly
in place of strtok_r; such a substitution, while it compiles, it doesn't
always run.


Yaakov
Cygwin Ports
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF+lMtpiWmPGlmQSMRCDPTAKDNpBMljJBISVsa5g2UijIU5wWgWwCfROOc
8acUkctBxwUCSQB9o2XRdtY=
=1hHH
-----END PGP SIGNATURE-----