Re: [gnome-db] Little API problems

[Murray Cumming <murrayc murrayc com>]

CCing the list because I think you forgot to.

Another thing:
The documentation for gda_client_create_database() mentions
gda_client_get_specs_to_create_database(). There is no such function,
though the name is used in the documentation for
gda_client_get_provider_specs(). I guess it's meant to provide the
GdaParameterList* somehow, but it returns a char*. Example code in the
documentation would help a lot here.

gda_client_drop_database() seems to have the same problem.

On Mon, 2005-09-12 at 13:52 -0500, Daniel Espinosa wrote:
> Yes, gda_value_set_type, must be implemented but using GdaValueType
> instead of GType.
> 
> it could be like:
> 
> GdaValue*
> gda_value_set_type(GdaValue* value, GdaValueType type)
> {
> 	g_return_if_fail (value);
> 
> 	l_g_value_unset (value);
> 	g_value_init (value, gdatype_to_gtype(type));
> }
> 
> This will return a GdaValue with out data.
> 
> 2005/9/12, Murray Cumming <murrayc murrayc com>:
> > I've noticed some things while wrapping the new libgda API:
> > 
> > GdaValue:
> > - gda_value_set_type(GdaValue*, GType) is declared but not implemented.
> > I can't imagine what it's meant to do. Maybe it's meant to take a
> > GdaValueType instead of a GType.
> > - gda_value_get_binary() returns a GdaBinary* which contains data and a
> > size, but the function also has a size output parameter.
> > - gda_value_set_binary() takes a gconstpointer of data, though
> > get_binary() returns a GdaBinary.
> > 
> > GdaColumnIndex:
> > - This is a reference-counted object, but it also has a
> >   gda_column_index_free() function. When would/could this be
> >   used? I'm pretty sure that it should be removed. It does a
> >   g_free() instead of a g_object_unref().
> > 
> > --
> > Murray Cumming
> > murrayc murrayc com
> > www.murrayc.com
> > www.openismus.com
> > 
> > 
> > _______________________________________________
> > gnome-db-list mailing list
> > gnome-db-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-db-list
> > 
> 
> 
-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com