Re: [gnome-db] patch: gda-postgres recset

[Rodrigo Moya <rodrigo gnome-db org>]

On Sat, 2005-01-08 at 00:20 +1000, Bas Driessen wrote:
> On Fri, 2005-01-07 at 12:07 +0100, Rodrigo Moya wrote:
> > On Fri, 2005-01-07 at 15:49 +1000, Bas Driessen wrote:
> > > Hello,
> > > 
> > > Attached a patch for the postgres provider. The append-row recset method
> > > needs to up the total number of rows in a data model. The attached patch
> > > takes care of that. 
> > > 
> > > Further it includes all changes in the same file as send yesterday (not
> > > to complicate roll-ins). It is a diff against the latest version in cvs.
> > > 
> > looks good, but missed the ChangeLog entry, could you please send a new
> > patch that includes that?
> > 
> 
> Thanks Rodrigo. Please find attached 2 patch files. If OK, the first one
> that needs to be applied is "gda-postgres-recset.patch". This one
> includes the changes as discussed earlier, but includes the ChangeLog
> entry as requested (and some minor format/cleanup changes). Rodrigo
> mentioned that my other patch is applied, so I have used that ChangeLog
> as starting point for the diff.
> 
> Then I followed up Vivien's advise and double checked the effect of the
> "R" marked rows on other gda-data-model functions. The only one that may
> be changed is the gda-data-model-foreach function. We can force it to
> skip the "R"emoved rows. If you agree, the change is in gda-data-
> model.patch and should be applied after the gda-postgres-recset.patch,
> since it uses that ChangeLog as starting point for the diff.
> 
> Regarding the returning of the number of rows in a data model. Even
> though the rows are marked, I believe it should not effect the total
> numbers of rows. Example; I have a data model with 10 rows. I remove row
> 2,4,6. So valid rows are 1,3,5,7,8 and 9. If I change the number of rows
> from 10 to 7, then it would not make sense to check row 9 for a value,
> since row 9 > max rows in the data model. Alternatively, a second
> function can be created like gda_data_model_get_active_n_rows that will
> return the number of active rows in a data model.
> 
> Please let me know your thoughts/concerns/advise etc :) .
> 
yes, some thoughts :)

If gda-data-model is to be removed, I guess this patch won't apply to
HEAD, am I wrong?
-- 
Rodrigo Moya <rodrigo gnome-db org>