Re: [gnome-db] libgnomedb usability patch

[Rodrigo Moya <rodrigo gnome-db org>]

On Sat, 2003-12-27 at 16:40, Laurent Sansonetti wrote:
> Hey guys,
> 
> (hope you had a nice xmas)
> 
yeah, nice ones, I hope you too :-)

> I found some time to improve a bit libgnomedb's usability.
> 
cool ...
> 
> ______________________________________________________________________
>  	bonobo_ui_component_set_prop (uic, "/commands/DatabaseNew", "hidden",
> -				      dsd->new_func ? "0" : "1",
> +				      dsd->callbacks->new_func ? "0" : "1",
> +				      NULL);
>
this should probably also be disabled when you switch to the providers
tab, since currently there is no way to add new providers from that GUI.

> +	/* FIXME: move this code in gnome_db_window_new () */
> +	uic = gnome_db_window_get_ui_component (GNOME_DB_WINDOW (dsd->shell));
> +	bonobo_ui_component_add_listener (uic, "ViewDataSources",
> +					  command_view_data_sources, dsd);
> +	bonobo_ui_component_add_listener (uic, "ViewProviders",
> +					  command_view_providers, dsd);
>  
why do you want to move it? Note that I'm not against it, just curious
:-)

apart from that it looks perfect, both codewise and when running! So
please, add the huge ChangeLog entry and commit :-)

thanks