Re: [gnome-db] A patch for nothing in particular

[Rodrigo Moya <rodrigo gnome-db org>]

On Thu, 2003-11-13 at 07:58, Paisa Seeluangsawat wrote:
> I'm trying to work on parts that are not dependent on update syntax
> for now.  Here's an errand patch.  This weekend, I'll work on,
> 
>   - remove const from GdaRow* and GdaValue*, and other glib/libgda structs
>     I see along the way.
> 
>   - implement is_null
> 
> If anyone objects to these two ideas, please speak NOW.  You hear
> it...now, not after the patch come...please.
> 
both things look perfect to me. Some comments inline:
 
> Index: libgda/gda-connection.c
> ===================================================================
> RCS file: /cvs/gnome/libgda/libgda/gda-connection.c,v
> retrieving revision 1.51
> diff -u -r1.51 gda-connection.c
> --- libgda/gda-connection.c	18 Oct 2003 23:03:52 -0000	1.51
> +++ libgda/gda-connection.c	13 Nov 2003 06:20:36 -0000
> @@ -207,7 +207,7 @@
>  	GdaDataSourceInfo *dsn_info;
>  	GdaQuarkList *params;
>  	const char *real_username = NULL;
> -	const char *real_password = NULL;
> +	char *real_password = NULL;
>  
I guess real_username should also not be const, since it's g_strdup'ed
below:

>  		if (dsn_info->username)
>  			real_username = g_strdup (dsn_info->username);

> Index: libgda/gda-row.c
> ===================================================================
> RCS file: /cvs/gnome/libgda/libgda/gda-row.c,v
> retrieving revision 1.36
> diff -u -r1.36 gda-row.c
> --- libgda/gda-row.c	11 Nov 2003 16:48:36 -0000	1.36
> +++ libgda/gda-row.c	13 Nov 2003 06:20:36 -0000
> @@ -48,7 +48,7 @@
>   * @model: the #GdaDataModel this row belongs to.
>   * @count: number of #GdaValue in the new #GdaRow.
>   *
> - * Creates a #GdaRow which can hold @count #GdaValue.
> + * Creates a #GdaRow from a list of #GdaValue's.
>   *
this comment is wrong, isn't it? The original one seems the correct one.

apart from that, looks ok, so please fix that and commit, only to HEAD.

Thanks