Re: [gnome-db] Patch for parameters and doc

[Rodrigo Moya <rodrigo gnome-db org>]

On Thu, 2003-05-08 at 21:22, Xabier Rodríguez Calvar wrote:
> El Martes, 6 de Mayo de 2003 11:06, Rodrigo Moya escribió:
> > On Tue, 2003-04-29 at 13:14, Xabier Rodríguez Calvar wrote:
> >
> > some comments:
> >
> >  GdaParameter *
> > -gda_parameter_new (const gchar *name, GdaValueType type)
> > +gda_parameter_new (const gchar *name, GdaValue *value)
> >  {
> >
> > I wouldn't use this at all. I would remove gda_parameter_new and add
> > gda_parameter_new_int/string/double..., and a
> > gda_parameter_new_from_value function. That would make the API more
> > consistent, and reduce confusion.
> 
> 	I disagree, because in the way you propose, the API is less extensible, 
> because if you want to create a new type into GdaValue class, you have to 
> change GdaParameter too, and in my way you don't have to :)
> 
then, add the gda_parameter_new_from_value function I'm talking about.

If you fix that (gda_parameter_new -> new_from_value) in your next
patch, I'll commit it.

cheers