Re: [gnome-db] Removed warnings from libgnomedb

[Gonzalo Paniagua Javier <gonzalo gnome-db org>]

	Again, I forgot to attach the files...

Index: libgnomedb/gnome-db-browser-tables.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-browser-tables.c,v
retrieving revision 1.9
diff -u -r1.9 gnome-db-browser-tables.c
--- libgnomedb/gnome-db-browser-tables.c	21 Mar 2002 02:28:12 -0000	1.9
+++ libgnomedb/gnome-db-browser-tables.c	21 Mar 2002 13:57:19 -0000
@@ -94,7 +94,6 @@
 	GdaCommand *cmd;
 	GdaDataModel *fields;
 	GdaParameterList *params;
-	GdaParameter *p;
 
 	g_return_if_fail (GTK_IS_WIDGET (widget));
 	g_return_if_fail (GDA_IS_CONNECTION (cnc));
Index: libgnomedb/gnome-db-browser-views.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-browser-views.c,v
retrieving revision 1.4
diff -u -r1.4 gnome-db-browser-views.c
--- libgnomedb/gnome-db-browser-views.c	21 Mar 2002 02:28:12 -0000	1.4
+++ libgnomedb/gnome-db-browser-views.c	21 Mar 2002 13:57:19 -0000
@@ -21,6 +21,7 @@
  */
 
 #include <bonobo/bonobo-i18n.h>
+#include <gtk/gtklabel.h>
 #include <gtk/gtknotebook.h>
 #include <libgnomedb/gnome-db-browser.h>
 #include <libgnomedb/gnome-db-grid.h>
Index: libgnomedb/gnome-db-data-source-selector.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-data-source-selector.c,v
retrieving revision 1.4
diff -u -r1.4 gnome-db-data-source-selector.c
--- libgnomedb/gnome-db-data-source-selector.c	10 Feb 2002 01:17:29 -0000	1.4
+++ libgnomedb/gnome-db-data-source-selector.c	21 Mar 2002 13:57:19 -0000
@@ -103,7 +103,7 @@
 	g_free (selector->priv);
 	selector->priv = NULL;
 
-	parent_class->finalize;
+	parent_class->finalize (object);
 }
 
 GType
Index: libgnomedb/gnome-db-dsn-config-druid.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-dsn-config-druid.c,v
retrieving revision 1.12
diff -u -r1.12 gnome-db-dsn-config-druid.c
--- libgnomedb/gnome-db-dsn-config-druid.c	3 Mar 2002 15:37:14 -0000	1.12
+++ libgnomedb/gnome-db-dsn-config-druid.c	21 Mar 2002 13:57:19 -0000
@@ -26,6 +26,7 @@
 #include <libgnomeui/gnome-druid-page-edge.h>
 #include <libgnomeui/gnome-druid-page-standard.h>
 #include <libgnomedb/gnome-db-dsn-config-druid.h>
+#include <libgnomedb/gnome-db-provider-selector.h>
 #include <libgnomedb/gnome-db-util.h>
 
 #define PARENT_TYPE GNOME_TYPE_DRUID
Index: libgnomedb/gnome-db-dsn-config.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-dsn-config.c,v
retrieving revision 1.5
diff -u -r1.5 gnome-db-dsn-config.c
--- libgnomedb/gnome-db-dsn-config.c	10 Feb 2002 01:17:29 -0000	1.5
+++ libgnomedb/gnome-db-dsn-config.c	21 Mar 2002 13:57:19 -0000
@@ -23,6 +23,7 @@
 #include <bonobo/bonobo-i18n.h>
 #include <gtk/gtktable.h>
 #include <libgnomedb/gnome-db-dsn-config.h>
+#include <libgnomedb/gnome-db-provider-selector.h>
 #include <libgnomedb/gnome-db-util.h>
 
 #define PARENT_TYPE GTK_TYPE_VBOX
Index: libgnomedb/gnome-db-error-dialog.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-error-dialog.c,v
retrieving revision 1.12
diff -u -r1.12 gnome-db-error-dialog.c
--- libgnomedb/gnome-db-error-dialog.c	3 Mar 2002 14:50:39 -0000	1.12
+++ libgnomedb/gnome-db-error-dialog.c	21 Mar 2002 13:57:19 -0000
@@ -25,6 +25,7 @@
 #include <gtk/gtkstock.h>
 #include <libgnomedb/gnome-db-error-dialog.h>
 #include <libgnomedb/gnome-db-util.h>
+#include <libgnomeui/gnome-window-icon.h>
 #include "gnome-db-intl.h"
 
 struct _GnomeDbErrorDialogPrivate {
Index: libgnomedb/gnome-db-form.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-form.c,v
retrieving revision 1.3
diff -u -r1.3 gnome-db-form.c
--- libgnomedb/gnome-db-form.c	21 Mar 2002 01:54:35 -0000	1.3
+++ libgnomedb/gnome-db-form.c	21 Mar 2002 13:57:19 -0000
@@ -270,7 +270,7 @@
 
 			if (gda_value_isa ((GdaValue *) value, GDA_VALUE_TYPE_BOOLEAN)) {
 				gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (l->data),
-							      gda_value_get_boolean (value));
+							      gda_value_get_boolean ((GdaValue *) value));
 			}
 			else {
 				str = gda_value_stringify ((GdaValue *) value);
Index: libgnomedb/gnome-db-grid.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-grid.c,v
retrieving revision 1.21
diff -u -r1.21 gnome-db-grid.c
--- libgnomedb/gnome-db-grid.c	17 Mar 2002 04:01:13 -0000	1.21
+++ libgnomedb/gnome-db-grid.c	21 Mar 2002 13:57:19 -0000
@@ -31,6 +31,7 @@
 #include <libgnomedb/gnome-db-model.h>
 #include <libgnomedb/gnome-db-stock.h>
 #include <libgnomedb/gnome-db-table-editor.h>
+#include <libgnomeui/gnome-window-icon.h>
 #include "gnome-db-intl.h"
 #include "libgnomedb-private.h"
 
@@ -90,7 +91,7 @@
 	/* create the dialog */
 	dialog = gtk_dialog_new_with_buttons (
 		_("Recordset description"),
-		GTK_WINDOW (gtk_widget_get_toplevel (grid)), 0,
+		GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (grid))), 0,
 		GTK_STOCK_CLOSE, GTK_RESPONSE_CANCEL,
 		NULL);
 	gnome_window_icon_set_from_file (GTK_WINDOW (dialog),
@@ -135,7 +136,7 @@
 	/* create the dialog */
 	dialog = gtk_dialog_new_with_buttons (
 		_("View detail"),
-		GTK_WINDOW (gtk_widget_get_toplevel (grid)), 0,
+		GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (grid))), 0,
 		GTK_STOCK_CLOSE, GTK_RESPONSE_CANCEL,
 		NULL);
 	gnome_window_icon_set_from_file (GTK_WINDOW (dialog),
Index: libgnomedb/gnome-db-login-dialog.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-login-dialog.c,v
retrieving revision 1.11
diff -u -r1.11 gnome-db-login-dialog.c
--- libgnomedb/gnome-db-login-dialog.c	3 Mar 2002 14:50:39 -0000	1.11
+++ libgnomedb/gnome-db-login-dialog.c	21 Mar 2002 13:57:19 -0000
@@ -24,6 +24,7 @@
 #include <gtk/gtkstock.h>
 #include <libgnomedb/gnome-db-login.h>
 #include <libgnomedb/gnome-db-login-dialog.h>
+#include <libgnomeui/gnome-window-icon.h>
 #include "gnome-db-intl.h"
 
 struct _GnomeDbLoginDialogPrivate {
Index: libgnomedb/gnome-db-model.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-model.c,v
retrieving revision 1.12
diff -u -r1.12 gnome-db-model.c
--- libgnomedb/gnome-db-model.c	21 Mar 2002 02:49:26 -0000	1.12
+++ libgnomedb/gnome-db-model.c	21 Mar 2002 13:57:19 -0000
@@ -20,6 +20,7 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#include <string.h>
 #include <libgnomedb/gnome-db-model.h>
 #include <libgnomedb/gnome-db-util.h>
 #include <gtk/gtkcellrenderertext.h>
@@ -186,7 +187,7 @@
 		return;
 
 	gtk_cell_renderer_toggle_set_active (GTK_CELL_RENDERER_TOGGLE (cell),
-					     gda_value_get_boolean (value));
+					     gda_value_get_boolean ((GdaValue *) value));
 }
 
 static gchar *double_underscores (const gchar *str)
Index: libgnomedb/gnome-db-util.c
===================================================================
RCS file: /cvs/gnome/libgnomedb/libgnomedb/gnome-db-util.c,v
retrieving revision 1.34
diff -u -r1.34 gnome-db-util.c
--- libgnomedb/gnome-db-util.c	16 Mar 2002 01:05:55 -0000	1.34
+++ libgnomedb/gnome-db-util.c	21 Mar 2002 13:57:19 -0000
@@ -53,6 +53,7 @@
 #include <libgnomedb/gnome-db-grid.h>
 #include <libgnomedb/gnome-db-intl.h>
 #include <libgnomedb/gnome-db-util.h>
+#include <libgnomeui/gnome-window-icon.h>
 
 /**
  * gnome_db_new_browser_widget

gnome-db-browser-tables.c: In function `gnome_db_browser_tables_show':
gnome-db-browser-tables.c:97: warning: unused variable `p'
gnome-db-browser-views.c: In function `gnome_db_browser_views_new':
gnome-db-browser-views.c:72: warning: implicit declaration of function `gtk_label_new'
gnome-db-browser-views.c:72: warning: passing arg 3 of `gtk_notebook_append_page' makes pointer from integer without a cast
gnome-db-data-source-selector.c: In function `gnome_db_data_source_selector_finalize':
gnome-db-data-source-selector.c:106: warning: statement with no effect
gnome-db-dsn-config-druid.c: In function `gnome_db_dsn_config_druid_init':
gnome-db-dsn-config-druid.c:306: warning: implicit declaration of function `gnome_db_provider_selector_new'
gnome-db-dsn-config-druid.c:306: warning: assignment makes pointer from integer without a cast
gnome-db-dsn-config.c: In function `gnome_db_dsn_config_init':
gnome-db-dsn-config.c:86: warning: implicit declaration of function `gnome_db_provider_selector_new'
gnome-db-dsn-config.c:86: warning: assignment makes pointer from integer without a cast
gnome-db-error-dialog.c: In function `gnome_db_error_dialog_new':
gnome-db-error-dialog.c:197: warning: implicit declaration of function `gnome_window_icon_set_from_file'
gnome-db-form.c: In function `show_navigator_row':
gnome-db-form.c:273: warning: passing arg 1 of `gda_value_get_boolean' discards qualifiers from pointer target type
gnome-db-grid.c: In function `menu_describe_cb':
gnome-db-grid.c:93: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
gnome-db-grid.c:96: warning: implicit declaration of function `gnome_window_icon_set_from_file'
gnome-db-grid.c: In function `menu_view_detail_cb':
gnome-db-grid.c:138: warning: passing arg 1 of `gtk_widget_get_toplevel' from incompatible pointer type
gnome-db-login-dialog.c: In function `gnome_db_login_dialog_new':
gnome-db-login-dialog.c:194: warning: implicit declaration of function `gnome_window_icon_set_from_file'
gnome-db-model.c: In function `toggle_value_set_func':
gnome-db-model.c:189: warning: passing arg 1 of `gda_value_get_boolean' discards qualifiers from pointer target type
gnome-db-model.c: In function `gnome_db_model_to_gtk_tree_view':
gnome-db-model.c:243: warning: implicit declaration of function `strchr'
gnome-db-util.c: In function `gnome_db_yes_no_dialog':
gnome-db-util.c:680: warning: implicit declaration of function `gnome_window_icon_set_from_file'
/usr/bin/jade:../libgnomedb-docs.sgml:74:65:E: general entity "GNOME-DB" not defined and no default entity