[gnome-cyr] [Bug 6447] Changed - Typing something in calendar view (day,workweek, entire week, month views) begins a new task ONLY if first character was ascii

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by hvv hippo ru 


--- shadow/6447	Tue Oct 30 13:41:56 2001
+++ shadow/6447.tmp.25682	Wed Oct 31 03:36:28 2001
@@ -79,6 +79,32 @@
 The function that starts editing is e_day_view_key_press() in
 evolution/calendar/gui/e-day-view.c.  There is an analogous function
 in e-week-view.c.
 Thanks, Vlad.  In the meantime I will compare it to other keyboard
 entry functions to see if we are missing something obvious...
+------- Additional Comments From hvv hippo ru  2001-10-31 03:36 -------
+Here is a code that matters from e-day-view.c:
+        if (keyval == GDK_Return) {
+                initial_text = NULL;
+        } else if ((keyval < 0x20)
+                   || (keyval > 0xFF) /*!!!!!*/
+                   || (event->length == 0)
+                   || (event->state & (GDK_CONTROL_MASK | GDK_MOD1_MASK))) {
+                return FALSE;
+        } else
+                initial_text = e_utf8_from_gtk_event_key (widget, event->keyval,
+Keysyms (aka keyvals) for russian have values > 0xff (e.g
+XK_Cyrillic_je = 0x6a8).
+So it seems "(keyval > 0xFF)" should be replaced with something less
+restrictive or completely removed (one has to scan keysyms that are
+arriving and decide which to filter out - I guess single Alt or Ctrl
+presses produce GdkEventKey - so we have to filter them - I suggest
+to turn it into
+|| (keyval > 0xFF00)
+ - see /usr/X11R6/include/X11/keysymdef.h for a list of all keysyms.
+On the other hand - it seems (event->length == 0) check will be enough
+to filter out all the "special" keys.
+Same change for week-view.c is needed too.
+ Thanks,
+  -Vlad

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]