Re: oaf speedup ...

[Maciej Stachowiak <mjs noisehavoc org>]

On 27Feb2002 09:18PM (+0000), Michael Meeks wrote:
> Hi Maciej,
> 
> 	After investigating quite why the server re-parses it's configuration
> files (a somewhat slow process) twice, I locate the culprit here:
> 
>         if (cur_time - 5 > servant->time_did_stat) {
>                 servant->time_did_stat = cur_time;
>                 
>                 for (i=0; servant->registry_source_directories[i];i++){
>                         if (registry_directory_needs_update 
>                             (servant,
> 			     servant->registry_source_directories[i])) {
>                                 must_load = TRUE;
> ****				break
>                         }
>                 }
>         }
> 
> 	The problem with this 'break' is that it ensures that the directory
> doesn't get into the hash with it's associated timestamp, thus you get
> multiple re-loads at 5 second intervals, 1 per prefix you use.

Nice catch.
 
> 	May I commit a fix to oaf ? fixed in bonobo-activation.
> 

In case it's not abundantly clear by now, you are free to do whatever
you want with oaf.

Sorry for responding to such an old message, my personal mail has been
down the past two weeks or so due to a massive screw-up at our ISP.

 - Maciej