Re: BonoboStream from Moniker [Patch]

[Michael Meeks <michael ximian com>]

Hi Jens,

On Sun, 2002-01-27 at 18:02, Jens Finke wrote:
> Ok, I have a patch ready (attached). But there is one problem I don't know
> how to cope with: The escaping of the ',' won't work. Within the moniker
> implementation you get always the unescaped string. This is because
> bonobo_moniker_set_name unescapes it always.

	Sorry to be slow to respond; ok - so firstly the result you get back
from bonobo_moniker_get_name is unescaped already, so we don't want to
apply an un-escaping again.

	Also, to find the ',' it's far better to do a strrchr than the current
code, IMHO.

> above example: Everything goes fine if you construct the moniker like:
> 
>  moniker = g_strconcat ("file:", bonobo_moniker_util_escape ("/foo.bar,w"),
>                         ",r", NULL);
> 
> The question is: Can we go with this design?

	Yes, sounds ok to me.

> Michael, what do you think?

	Sounds great - can you re-hash the patch though ? we also don't want to
be adding the ',' to the escaped whatnots I think - that looks broken to
me.

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot