Re: bonobo-storage-memory.c

[ERDI Gergo <cactus cactus rulez org>]

On Thu, 8 Nov 2001, Michael Meeks wrote:

>         I have ( as always ) a few comments :-) if you could fixup and    
> commit (&CC) that'd be great.

I hope you realize that you sound more and more like the manager in Office
Space with every checkin approval of yours..


Index: bonobo/bonobo-storage-memory.c
===================================================================
RCS file: /cvs/gnome/libbonobo/bonobo/bonobo-storage-memory.c,v
retrieving revision 1.7
diff -u -u -r1.7 bonobo-storage-memory.c
--- bonobo/bonobo-storage-memory.c	2001/11/08 23:10:16	1.7
+++ bonobo/bonobo-storage-memory.c	2001/11/09 13:20:24
@@ -439,8 +439,7 @@
  ok_out:
 	g_free (path_last);
 	
-	return bonobo_object_dup_ref (bonobo_object_corba_objref (stream),
-				      NULL);
+	return bonobo_object_dup_ref (BONOBO_OBJREF (stream), ev);
 	
  ex_out:
 	g_free (path_last);
@@ -504,8 +503,7 @@
  ok_out:
 	g_free (path_last);
 	
-	return bonobo_object_dup_ref (bonobo_object_corba_objref (ret),
-				      NULL);
+	return bonobo_object_dup_ref (BONOBO_OBJREF (ret), ev);
 	
  ex_out:
 	g_free (path_last);
Index: tests/test-storage-mem.c
===================================================================
RCS file: /cvs/gnome/libbonobo/tests/test-storage-mem.c,v
retrieving revision 1.4
diff -u -u -r1.4 test-storage-mem.c
--- tests/test-storage-mem.c	2001/11/08 23:10:17	1.4
+++ tests/test-storage-mem.c	2001/11/09 13:20:24
@@ -134,7 +134,6 @@
 		CORBA_exception_free (ev);
 	}
 
-#if 1
 	printf ("getInfo (storage):\t");
 	num_tests++;
 	info = Bonobo_Storage_getInfo (corba_storage,
@@ -296,17 +295,13 @@
 		CORBA_exception_free (ev);
 	}
 	CORBA_exception_free (ev);
-#endif
+
+	bonobo_object_unref (BONOBO_OBJECT (storage));
 	
 	printf ("%d of %d tests passed\n", num_ok, num_tests);
 	
 	if (num_ok != num_tests)
 		return 1;
 
-	bonobo_object_unref (BONOBO_OBJECT (storage));
-	
-	printf ("FIXME: bonobo-storage-memory is just too perfect!\n");
-	
-	/* return bonobo_debug_shutdown (); */
-	return 0;
+	return bonobo_debug_shutdown ();
 }

-- 
   .--= ULLA! =---------------------.   `We are not here to give users what
   \     http://cactus.rulez.org     \   they want'  -- RMS, at GUADEC 2001
    `---= cactus cactus rulez org =---'
Minden általánosítás hamis, ezzel együtt.