Re: BonoboUIComponent missing preconditions

[Jonathan Blandford <jrb redhat com>]

Ettore Perazzoli <ettore ximian com> writes:

> >         Please remove the redundant:
> > 
> > **      g_return_if_fail (a != NULL);        **
> >         g_return_if_fail (BONOBO_IS_FOO (a));
> > 
> >         since that check is integrated, and we want to keep line count
> > low and readable.
> 
>   The standard way in the GNOME/GTK world is to do both, but whatever.

In GTK+-2.0 we've tried to remove the a != NULL checks in favor of just
GTK_IS_FOO (a) checks, as the a != NULL checks are now redundant.  In
most cases this is not a bottleneck, though it can be if used
inappropriately, etc...

Thanks,
-Jonathan