Re: BonoboUIComponent missing preconditions
- From: Ettore Perazzoli <ettore ximian com>
- To: Michael Meeks <michael ximian com>
- Cc: gnome-components-list gnome org
- Subject: Re: BonoboUIComponent missing preconditions
- Date: 02 Jul 2001 23:34:58 -0400
> Please remove the redundant:
>
> ** g_return_if_fail (a != NULL); **
> g_return_if_fail (BONOBO_IS_FOO (a));
>
> since that check is integrated, and we want to keep line count
> low and readable.
The standard way in the GNOME/GTK world is to do both, but whatever.
> Secondly, I removed some of the preconditions - of the type
>
> g_return_if_fail (BONOBO_IS_UI_COMPONENT (uic));
>
> on some of the methods, since that's a slow check - and some
> of those are called scads of times - in this case it's nice to have a
Man. We are talking of the Bonobo UI handling code here. It spends
all its time doing XML parsing. You could only wish this was a
bottleneck!
--
Ettore
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]