Re: revised patch ...

[Darin Adler <darin bentspoon com>]

On Tuesday, July 17, 2001, at 05:00  PM, Michael Meeks wrote:

> @@ -134,7 +134,7 @@
>  	(gpointer) &impl_OAF_ObjectDirectory_activate,
>  	(gpointer) &impl_OAF_ObjectDirectory_lock,
>  	(gpointer) &impl_OAF_ObjectDirectory_unlock,
> -	(gpointer) &impl_OAF_ObjectDirectory_register,
> +	(gpointer) &impl_OAF_ObjectDirectory_register_new,
>  	(gpointer) &impl_OAF_ObjectDirectory_unregister
>  };

These gpointer casts are an abomination! But that has nothing to do with 
your patch.

> @@ -163,6 +163,10 @@
>  			OAF_Property *prop =
>  				&(od->attr_servers._buffer[i].
>  				  props._buffer[j]);
> +                        if (strstr (prop->name, "-")) /* Translated, 
> likely to
> +                                                         be annoying 
> garbage value */
> +                                continue;
> +

As I said before, you probably need to g_print ("\n") here, since we 
already printed stuff out and didn't do a newline yet. Was I wrong?

Otherwise looks fine to me.

    -- Darin