Re: bonobo-moniker-extender-file.c change.



Dave Camp <dave ximian com> writes:

> I just committed this one-liner to bonobo, to improve the mime handling
> of bonobo-moniker-extender-file:

Hi Dave,

if you're "fixing" things, can you please do it correctly next time. So now
that this file is now in libgnome, can you please have a look at it again
whether it's still correct ?

Maybe you didn't realize that you changed a call to the following function
(which doesn't exist anymore, btw):

====
#include <libgnomevfs/gnome-vfs-mime.h>
/* This declaration is only here to make -Werror happy. */
extern const char *gnome_mime_type (const char *);

const char *
gnome_mime_type (const char *filename)
{
    g_warning (G_STRLOC ": You will be killed if you use this function!");

    return gnome_vfs_mime_type_from_name (filename);
}
====

to something which is just an undefined symbol on the GNOME 2 platform.

-- 
Martin Baulig
martin gnome org (private)
baulig suse de (work)




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]