Re: Patch to optimize bonobo's hex encoding functions



Hi John, 
   
On Mon, 26 Feb 2001, John Harper wrote:
> This patch makes the read_byte and write_byte functions in
> bonobo-ui-util.c use lookup tables to do the conversion. I've done
> timings both before and after, and the patch increases speed per byte
> by around 80-100% (on my PIII)

        Thanks, they were rather high on the profile for Nautilus - so
I'll treat this as a bug.

        Please commit the patch having removed the redundant braces such   
as:

> +     if (nibble1 < 0 || nibble2 < 0) {
> +             read_warning (start);
> +     }
  
        Thanks,
  
                Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]