Re: Patch to optimize bonobo's hex encoding functions
- From: Michael Meeks <michael ximian com>
- To: John Harper <jsh eazel com>
- Cc: gnome-components-list gnome org
- Subject: Re: Patch to optimize bonobo's hex encoding functions
- Date: Tue, 27 Feb 2001 05:07:22 -0500 (EST)
Hi John,
On Mon, 26 Feb 2001, John Harper wrote:
> This patch makes the read_byte and write_byte functions in
> bonobo-ui-util.c use lookup tables to do the conversion. I've done
> timings both before and after, and the patch increases speed per byte
> by around 80-100% (on my PIII)
Thanks, they were rather high on the profile for Nautilus - so
I'll treat this as a bug.
Please commit the patch having removed the redundant braces such
as:
> + if (nibble1 < 0 || nibble2 < 0) {
> + read_warning (start);
> + }
Thanks,
Michael.
--
mmeeks gnu org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]