Re: An interesting hack ?

[Federico Mena Quintero <federico ximian com>]

Michael Meeks <michael ximian com> writes:

> bonobo-control.c: In function `impl_Bonobo_Control_focus':
> bonobo-control.c:477: warning: `direction' might be used uninitialized in
> this function
> 
> 	I appreciate your fixes - but a warning and a really
> obvious brokenness:
> 
> 	switch (corba_direction) {
> 	case Bonobo_Control_TAB_FORWARD:
> 		direction = GTK_DIR_TAB_FORWARD;
> 		break;
> 
> 	case Bonobo_Control_TAB_BACKWARD:
> 		corba_direction = GTK_DIR_TAB_BACKWARD;
> 		break;

Argh.

You know why that happened?

That happened because I am a fucking moron and cut&pasted that code.

It is fixed now :-(

> 	/* FIXME: this will not work for local controls. */
> 
> 	Is this correct ? is this neccessary, why can't we
> detect the local case using is_local ? is it really broken ?

I haven't tested local controls at all, but let me take a look.

I am still stumped with the focus-out-of-an-embedded-control case :-(

  Federico