Re: Okay to commit? PATCH to bonobo-activation -- adds glib-gettextize support and migrates configure.in to meet Gnome 2.0 Porting Guide recommendations.



Looks all right to me, although I'm a bit disappointed that for GNOME
2.0, a simple call to AM_INIT_AUTOMAKE needs to be replaced with 3
macro calls.

Go ahead and commit.

 - Maciej

On 14Dec2001 12:00PM (-0800), Miles Lane wrote:
> diff -u --new-file acconfig.h.old acconfig.h 
> --- acconfig.h.old	Fri Dec 14 11:36:42 2001
> +++ acconfig.h	Fri Dec 14 11:28:32 2001
> @@ -5,5 +5,6 @@
>  #undef ENABLE_NLS
>  #undef HAVE_CATGETS
>  #undef HAVE_GETTEXT
> +#undef GETTEXT_PACKAGE
>  #undef HAVE_LC_MESSAGES
>  #undef HAVE_STPCPY
> diff -u --new-file configure.old configure.in 
> --- configure.old	Fri Dec 14 11:36:42 2001
> +++ configure.in	Fri Dec 14 01:00:07 2001
> @@ -1,5 +1,4 @@
>  dnl Process this file with autoconf to produce a configure script.
> -AC_INIT(idl/Bonobo_ActivationContext.idl)
>  
>  BONOBO_ACTIVATION_MAJOR_VERSION=0
>  BONOBO_ACTIVATION_MINOR_VERSION=9
> @@ -7,7 +6,11 @@
>  BONOBO_ACTIVATION_INTERFACE_AGE=0
>  BONOBO_ACTIVATION_BINARY_AGE=0
>  BONOBO_ACTIVATION_VERSION="$BONOBO_ACTIVATION_MAJOR_VERSION.$BONOBO_ACTIVATION_MINOR_VERSION.$BONOBO_ACTIVATION_MICRO_VERSION"
> -AM_INIT_AUTOMAKE(bonobo-activation, $BONOBO_ACTIVATION_VERSION)
> +
> +AC_INIT(bonobo-activation, 0.9.3, http://bugzilla.gnome.org/enter_bug.cgi?product=bonobo-activation)
> +AC_CONFIG_SRCDIR(idl/Bonobo_ActivationContext.idl)
> +AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, $BONOBO_ACTIVATION_VERSION)
> +
>  AC_SUBST(BONOBO_ACTIVATION_MAJOR_VERSION)
>  AC_SUBST(BONOBO_ACTIVATION_MINOR_VERSION)
>  AC_SUBST(BONOBO_ACTIVATION_MICRO_VERSION)
> @@ -53,9 +56,13 @@
>  
>  dnl internationalization support
>  ALL_LINGUAS="az da de el es fi fr ga gl hu it ja ko nl nn no pl pt_BR ro ru sk sl sv ta tr uk pl zh_CN zh_TW"
> -AM_GNOME2_GETTEXT
>  
> -GNOME_COMMON_INIT
> +GETTEXT_PACKAGE=bonobo-activation
> +AC_SUBST(GETTEXT_PACKAGE)
> +AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE")
> +
> +AM_GLIB_GNU_GETTEXT
> +
>  GNOME_PLATFORM_GNOME_2(yes, force)
>  
>  dnl Checks for libraries.
> 
> 
> _______________________________________________
> gnome-components-list mailing list
> gnome-components-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-components-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]