Patch for Bag bug



Here's the patch for Troy's bug discovery in the bag notify_listener
/set_value functions.

I took the liberty of checking it in since it's pretty straightforward.

Mike
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/bonobo/ChangeLog,v
retrieving revision 1.684
diff -u -r1.684 ChangeLog
--- ChangeLog	2000/10/23 21:26:29	1.684
+++ ChangeLog	2000/10/25 03:45:58
@@ -1,3 +1,9 @@
+2000-10-24  Mike Kestner  <mkestner ameritech net>
+
+	* bonobo/bonobo-property-bag.c (bonobo_property_bag_set_value): Fix
+	for the precondition bug that Troy Gillette discovered.
+	(bonobo_property_bag_notify_listeners): Ditto.
+
 2000-10-23  Zach Frey  <zfrey bright net>
 
 	* doc/api/Makefile.am: update.
Index: bonobo/bonobo-property-bag.c
===================================================================
RCS file: /cvs/gnome/bonobo/bonobo/bonobo-property-bag.c,v
retrieving revision 1.24
diff -u -r1.24 bonobo-property-bag.c
--- bonobo/bonobo-property-bag.c	2000/10/17 16:58:46	1.24
+++ bonobo/bonobo-property-bag.c	2000/10/25 03:46:00
@@ -963,7 +963,7 @@
 	prop = g_hash_table_lookup (pb->priv->props, name);
 
 	g_return_if_fail (prop != NULL);
-	g_return_if_fail (prop->type != new_value->_type);
+	g_return_if_fail (prop->type == new_value->_type);
 
 	notify_listeners (pb, prop, new_value, ev);
 }
@@ -984,7 +984,7 @@
 
 	g_return_if_fail (prop != NULL);
 	g_return_if_fail (prop->set_prop != NULL);
-	g_return_if_fail (prop->type != value->_type);
+	g_return_if_fail (prop->type == value->_type);
 
 	prop->set_prop (pb, value, prop->idx, prop->user_data);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]