[PATCH] oaf compilation fixes
- From: Jason Leach <leach wam umd edu>
- To: gnome-components-list gnome org
- Subject: [PATCH] oaf compilation fixes
- Date: Sat, 11 Nov 2000 09:55:15 -0500
Hi oaf hackers,
Just doing the regular bug cleaning and squashing, and saw on
bugs.gnome.org that a nice user had made 3 reports of compilation
problems each including a patch, spanning 3 different oaf releases
back to May 11. Probably should have been looked at earlier, but
we're only free software hackers.
The bugs are #10807, #17146, and #31209, all basically about the same
problem:
- on alpha-dec-osf4.0f, hppa1.1-hp-hpux10.20, mips-sgi-irix6.5 and
powerpc-ibm-aix4.3.2.0, compilation stops at oaf-registration.c
So, here's a patch for it, I'd commit it but I don't wanna get yelled
at because I'm not an oaf hacker :) On a side note, checked into the
changes myself, and g_strsignal does indeed look well designed. You
could probably remove the whole #ifdef'ing for HAVE_STRSIGNAL part and
oaf_strsignal defs and just make calls to g_strsignal. This larger
oaf change would be up to you guys though.
The attached patch also includes a fix for the other noted problems in
his latest report:
- on hppa1.1-hp-hpux10.20, mips-sgi-irix6.5 and powerpc-ibm-aix4.3.2,
oafd and utils cannot be linked as -lintl is not in the link
command.
Someone please commit this patch or a slightly modified patch so I can
close these 3 bugs and personally mail thanks to this patient user.
Thanks,
Jason.
? oaf.patch
Index: liboaf/oaf-registration.c
===================================================================
RCS file: /cvs/gnome/oaf/liboaf/oaf-registration.c,v
retrieving revision 1.22
diff -u -r1.22 oaf-registration.c
--- liboaf/oaf-registration.c 2000/10/30 05:14:12 1.22
+++ liboaf/oaf-registration.c 2000/11/11 14:19:23
@@ -263,17 +263,8 @@
#ifdef HAVE_STRSIGNAL
#define oaf_strsignal strsignal
#else
-static char *
-oaf_strsignal (int sig)
-{
- if (sig < NSIG)
- return sys_siglist[sig];
- else
- return "Unknown signal";
-
-}
+#define oaf_strsignal g_strsignal
#endif
-
static
void oaf_setenv (const char *name, const char *value)
Index: oafd/Makefile.am
===================================================================
RCS file: /cvs/gnome/oaf/oafd/Makefile.am,v
retrieving revision 1.19
diff -u -r1.19 Makefile.am
--- oafd/Makefile.am 2000/10/06 04:25:33 1.19
+++ oafd/Makefile.am 2000/11/11 14:19:23
@@ -38,6 +38,7 @@
LDADD=../liboaf/liboaf.la \
@ORBIT_LIBS@ -lORBitCosNaming -lname-server \
@XML_LIBS@ \
+ @INTLLIBS@ \
@GLIB_LIBS@
oaf_client_SOURCES=client.c
Index: utils/Makefile.am
===================================================================
RCS file: /cvs/gnome/oaf/utils/Makefile.am,v
retrieving revision 1.3
diff -u -r1.3 Makefile.am
--- utils/Makefile.am 2000/07/31 15:56:17 1.3
+++ utils/Makefile.am 2000/11/11 14:19:23
@@ -19,4 +19,5 @@
oaf_sysconf_LDADD = \
$(XML_LIBS) \
$(GLIB_LIBS) \
+ $(INTLLIBS) \
$(NULL)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]