Re: small patch to bonobo-object.c to get rid of copy/paste code



Darin Adler <darin@eazel.com> writes:

> The main change here is to make bonobo_object_unref use
> bonobo_object_destroy. A minor tweak I did at the same time is that
> BONOBO_IS_OBJECT, like all the GtkObject type check macros, includes a check
> for NULL, so I got rid of a lot of redundant separate checks for NULL.
> 
> I'll check this in after a day or two if I don't hear from anyone.
> 

Darin, I think for your patch to make sense you also need to make
bonobo_object_destroy set the refcount to 0, as things stand now, it
will never get to zero. In fact, it should be set to zero before all
the gtk_object_destroy calls in bonobo_object_destroy.

 - Maciej



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]