Re: RGB UI Diff done using -u

[Nat Friedman <nat helixcode com>]

"Gene Z. Ragan" <gzr@eazel.com> writes:

> My aplogies to the list.  Here is a proper diff done using -u.

Some initial comments:

1. We should probably rename the type to BONOBO_UI_HANDLER_PIXMAP_PIXBUF

2. Will your to_corba function work if the other end is different
   endianness?  I would guess 'yes' but I don't know what
   gdk_pixbuf_get_pixels returns.

3. I think that some of these functions which are large switch
   statements should be broken into multiple small functions driven by
   the switch.  They're starting to get unwieldy.


Overall, looks good.  We have to get that autoconf test fixed though.
And I haven't tested it.

Makes me wish we had aa toolbars, too.

Nat