Re: patch for ownership problem in bonobo-uih-menu.c



on 3/7/00 4:04 PM, Nat Friedman at nat@helixcode.com wrote:

> 
> John Sullivan writes:
>> Here's another patch for a problem Nautilus has run into with bonobo menus.
>> When quitting, the bonobo menu items are destroyed in the normal way by the
>> widget hierarchy being torn down, then they get accessed in bonobo and spew
>> GTK-CRITICALs all over the place.
>> 
>> Should I go ahead and commit this simple change? I'm not sure if there's
>> some other solution, but these two gtk_object_ref calls fix the symptom.
> 
> That looks to me like the correct solution.  Thanks for helping out so
> much, John.  I feel bad about that code but have been too busy to work
> on it lately.
> 
> Nat

After creating this patch, I found a parallel problem in
bonobo-uih-toolbar.c. I'll commit that fix at the same time.

John



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]