bug in get_filtered_objects - patch for review, please
- From: Nat Friedman <nat helixcode com>
- To: Christopher Blizzard <blizzard mozilla org>
- Cc: nat helixcode com, miguel helixcode com, Elliot Lee <sopwith redhat com>, Chris Blizzard <blizzard redhat com>, gnome-components-list gnome org, Havoc Pennington <hp pobox com>
- Subject: bug in get_filtered_objects - patch for review, please
- Date: Fri, 4 Feb 2000 13:12:07 -0500 (EST)
Christopher Blizzard writes:
> There seems to be a bug in get_filtered_objects which is called from
> add_gnorba_objects. It looks like it's supposed to return a GList that
> contains a list of the valid servers that are supposed to be used in the
> selector widget. It uses the local "object" GList variable but nothing
> is ever assigned to that variable so this function will always return
> NULL. The attached patch fixes it. Let me know if I can check it in.
> The sample container won't run without it. It never finds clients that
> can be added to the container. Thanks.
The patch is fine. Please commit. The problem is that Havoc's
Oaf/Goad/OD patch broke BonoboSelector, and I guess he never tested
it.
Nat
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]