Leak in oafd
- From: Ali Abdin <aliabdin aucegypt edu>
- To: mjs eazel com
- Cc: gnome-components-list gnome org, darin eazel com
- Subject: Leak in oafd
- Date: Sun, 24 Dec 2000 16:14:02 -0200
I discovered a leak in oafd. Basically, the pathname in
od_load_directory was not being freed. The patch is against
oaf-stable-0-6. HEAD does not appear to have this bug.
Can I commit?
? leak-fix.diff
? api-docs/man
? po/Makefile.in.in
cvs server: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/oaf/ChangeLog,v
retrieving revision 1.126.2.10
diff -u -r1.126.2.10 ChangeLog
--- ChangeLog 2000/12/20 03:09:54 1.126.2.10
+++ ChangeLog 2000/12/24 13:57:43
@@ -1,3 +1,8 @@
+2000-12-24 Ali Abdin <aliabdin aucegypt edu>
+
+ * oafd/od-load.c (od_load_directory): Free the pathname. It was
+ getting leaked.
+
2000-12-19 Maciej Stachowiak <mjs eazel com>
reviewed by: Rebecca Schulman <rebecka eazel com>
cvs server: Diffing api-docs
cvs server: Diffing api-docs/tmpl
cvs server: Diffing docs
cvs server: Diffing idl
cvs server: Diffing liboaf
cvs server: Diffing oafd
Index: oafd/od-load.c
===================================================================
RCS file: /cvs/gnome/oaf/oafd/od-load.c,v
retrieving revision 1.19.4.1
diff -u -r1.19.4.1 od-load.c
--- oafd/od-load.c 2000/11/23 05:27:46 1.19.4.1
+++ oafd/od-load.c 2000/12/24 13:57:44
@@ -333,6 +333,8 @@
od_filename_has_extension (pathname, ".oafinfo")) {
od_load_file (pathname, entries, host, domain);
}
+
+ g_free (pathname);
}
closedir (directory_handle);
cvs server: Diffing po
cvs server: Diffing test
cvs server: Diffing utils
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]