Camera Profiling GUI Dialog Order

[Pascal de Bruijn <pmjdebruijn pcode nl>]

Hi,

Currently to profile a camera, the GUI first asks for both files, and
then asks for the chart type... This seems odd to me...

It seems more natural to me, to first ask about the chart type, and
then ask about the files...

Regards,
Pascal de Bruijn

diff -Nurpd gcm-orig/src/gcm-prefs.c gcm-hack/src/gcm-prefs.c
--- gcm-orig/src/gcm-prefs.c	2010-02-08 21:57:27.000000000 +0100
+++ gcm-hack/src/gcm-prefs.c	2010-02-08 22:46:26.000000000 +0100
@@ -802,6 +802,14 @@ gcm_prefs_calibrate_device (GcmCalibrate
 		      "manufacturer", &manufacturer,
 		      NULL);
 
+	/* set the reference kind */
+	reference_kind = gcm_prefs_get_reference_kind ();
+	if (reference_kind == GCM_CALIBRATE_ARGYLL_REFERENCE_KIND_UNKNOWN) {
+		ret = FALSE;
+		goto out;
+	}
+	gcm_calibrate_argyll_set_reference_kind (GCM_CALIBRATE_ARGYLL (calibrate), reference_kind);
+
 	/* get scanned image */
 	directory = g_get_home_dir ();
 	scanned_image = gcm_prefs_calibrate_device_get_scanned_profile (directory);
@@ -814,14 +822,6 @@ gcm_prefs_calibrate_device (GcmCalibrate
 	if (reference_data == NULL)
 		goto out;
 
-	/* set the reference kind */
-	reference_kind = gcm_prefs_get_reference_kind ();
-	if (reference_kind == GCM_CALIBRATE_ARGYLL_REFERENCE_KIND_UNKNOWN) {
-		ret = FALSE;
-		goto out;
-	}
-	gcm_calibrate_argyll_set_reference_kind (GCM_CALIBRATE_ARGYLL (calibrate), reference_kind);
-
 	/* ensure we have data */
 	basename = gcm_prefs_calibrate_get_basename (current_device);
 	if (manufacturer == NULL)