Why not using strftime?



Hi,

As I didn't find any bug tracker now, I'm reporting this here. I wonder
why you're using a complicated machinery with
gcm_utils_format_date_time/gcm_utils_month_to_localized_text instead of
simply using strftime call in gcm-profile.c

Something like (not tested code):
        ret = cmsTakeCreationDateTime (&created, priv->lcms_profile);
        if (ret)
-               priv->datetime = gcm_utils_format_date_time (1900
+created.tm_year, created.tm_mon+1, created
+               /* Translators: this is the profile creation date
strftime format */
+               strftime (priv->datetime, sizeof(priv->datetime), _("%d
%B %Y, %H:%M:%S"), created);

Months names should not be translated again, this is a waste of time for
translators.
 
Claude

P.S. Please cc me on answer



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]