Re: MPNumber struct instead of int[MP_SIZE]

["Robert Ancell" <robert ancell gmail com>]

Looks good to me; the only question I have is what is the change to
mkinstalldirs for?

I look forward to the final patch (for others not following this the
bug this work is for is:
http://bugzilla.gnome.org/show_bug.cgi?id=524091)

--Robert

2008/10/12  <Klaus Niederkrueger umpa ens-lyon fr>:
> Hi,
>
> Please review the code, and tell me what you think, if you have time at
> least.
> I changed the datatype for the numbers in the mp-core from int[] to a
> structure MPNumber, defined as
>
> typedef struct {
>  /* if sign == 0, then whole MPNumber is zero. Otherwise sign == 1 or
>     -1 */
>  int sign;
>  int exp;
>  int mant[MP_SIZE-2];
>  /* I believe exp == 1 is integer ... or is exp == 0 already large
>     enough */
> } MPNumber;
>
> The program does not yet compile cleanly (lots of warnings about wrong
> pointer types), because I did not yet complete the transition of all of
> the code.  But the unittests still work as before (three functions still
> fail, the others give ok).
>
> Cheers
>
> Klaus
> _______________________________________________
> gcalctool-list mailing list
> gcalctool-list gnome org
> http://mail.gnome.org/mailman/listinfo/gcalctool-list