Magnifier DBus interface vs GSettings



There is a mismatch between some of the magnifier's GSettings and the magnifier DBus interface.

An example is enabling and disabling the magnifier. It's currently possible to do this through GSettings, and via the DBus setActive() method. This can lead to an inconsistency if the GSetting is set to "off" and the DBus method is used to enable the magnifier. In that case, the magnifier will be active, but shown as off in the GNOME Control Center.

There are a number of ways to fix this. My preference is to delete the DBus method. That is, having a magnifier active/inactive is a user preference, and the way to handle that is to make the appropriate settings call.

I would similarly remove the DBus method for adjusting magnification factor since, again, GSettings provides the support for modifying magnification factor. In fact, the Common Magnifier Framework proposal had mag factor supported only by GSettings (http://live.gnome.org/Accessibility/MagnificationFramework).

However, before I make these changes to GS-mag's DBus implementation, I wanted to make sure that no one depends on their existence.

Any objections?

Note:  the relevant bugzilla is:
https://bugzilla.gnome.org/show_bug.cgi?id=669192

Thanks.

--
;;;;joseph.


'A: After all, it isn't rocket science.'
'K: Right. It's merely computer science.'
             - J. D. Klaun -



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]