Re: 'make' compilation error with gnopernicus

[Adi Dascal <ad baum ro>]

Hi Tatus,

The problem that seems to appear on your machine is that the errno (number of 
last error) is not found. 
The  integer  errno is set by system calls (and some library functions) to 
indicate what went wrong.  Its value is significant only when the  call  
returned  an  error (usually  -1), and a library function that does succeed 
is allowed to change errno.

This omision can be considered as a bug for gnopernicus, because in one of 
the braille's file, sercomm.c, there is no #include <errno.h>. Including this 
file in sercomm.c should solve the problem on any platform, and any 
configuration.

BUT since the use of errno is redundant in our code I got rid of it, so 
changes are in CVS now, but just in case I will attach the patch to this 
email, too. (copy the patch in the root directory of gnopernicus and then
patch -p0 < libbrl.diff  OR get the new sources from CVS).

Best regards,
Adi Dascal
PS: Please confirm me that this patch/the new sources fixes your problem. 
Thanks!

On Tuesday 25 February 2003 16:42, Tatus Maximus wrote:
> Hey all,
>
> Thanks for the quick responses.  Sorry about the lack of information.  Here
> is some more:
>
> OS:
> Redhat8.1 Beta5 "Phoebe"
> Gnome version 2.2 - stack is located in /usr/share
>
> Hardware:
> 2.0 GHz/400fsb P4 Northwood Processor
> Intel 845 Chipset planar
> 40GB Maxtor Hard Drive
> 128MB DDR-SDRAM
> 48x cdrom
> Intel 845 On Board video (sharing 8mb system ram through bios)
> Intel ADI 1981 On Board audio
>
> Device Drivers:
> All device drivers are stock Redhat drivers
>
> Here is a larger cut and paste from the 'make' output:
>
> /bin/sh ../../mkinstalldirs /usr/local/include/gnopernicus-1.0/libbrl
> /usr/bin/install -c -m 644 brlxmlapi.h
> /usr/local/include/gnopernicus-1.0/libbrl/brlxmlapi.h
> make[3]: Leaving directory
> `/opt/gnopernicus_install_files/gnopernicus/braille/libbrl'
> make[2]: Leaving directory
> `/opt/gnopernicus_install_files/gnopernicus/braille/libbrl'
> Making install in test
> make[2]: Entering directory
> `/opt/gnopernicus_install_files/gnopernicus/braille/test'
> /bin/sh ../../libtool --mode=link gcc  -Wall -g
> -DGNOPERNICUSLOCALEDIR=\""/usr/local/share/locale"\"  -o tester  tester.o
> brlinp.o ../libbrl/libbrl.la ../../srutil/libsrutil.la
> ../../srconf/libsrconf/libsrconf.la -Wl,--export-dynamic -pthread
> -L/usr/local/lib -L/usr/X11R6/lib -lgnomeui-2 -lSM -lICE -lbonoboui-2
> -lgnomecanvas-2 -lgnome-2 -lart_lgpl_2 -lpangoft2-1.0 -lgtk-x11-2.0
> -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangoxft-1.0 -lpangox-1.0
> -lpango-1.0 -lbonobo-2 -lgconf-2 -lgnomevfs-2 -lbonobo-activation -lORBit-2
> -lgmodule-2.0 -ldl -llinc -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lxml2 -lz
> -lm   -lpopt
> gcc -Wall -g -DGNOPERNICUSLOCALEDIR=\"/usr/local/share/locale\" -o
> .libs/tester tester.o brlinp.o -Wl,--export-dynamic -pthread
> ../libbrl/.libs/libbrl.so -L/opt/gnome-2.0/lib
> ../../srutil/.libs/libsrutil.so -L/usr/X11R6/lib
> ../../srconf/libsrconf/.libs/libsrconf.so /usr/local/lib/libcspi.so
> /usr/local/lib/libspi.so -lX11 /usr/lib/libgailutil.so -lXtst
> -L/usr/local/lib /usr/local/lib/libgnomeui-2.so /usr/lib/libjpeg.so -lSM
> -lICE -lbonoboui-2 -lgnomecanvas-2 /usr/local/lib/libgnome-2.so
> /usr/lib/libxml2.so -lesd -laudiofile -lart_lgpl_2 -lpangoft2-1.0
> /usr/local/lib/libgtk-x11-2.0.so /usr/local/lib/libgdk-x11-2.0.so -latk-1.0
> /usr/local/lib/libgdk_pixbuf-2.0.so -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0
> -lbonobo-2 /usr/local/lib/libgconf-2.so
> -lgnomevfs-2 -lbonobo-activation -lORBit-2 /usr/local/lib/libgmodule-2.0.so
> -ldl /usr/lib/liblinc.so /usr/local/lib/libgobject-2.0.so
> /usr/local/lib/libgthread-2.0.so -lpthread /usr/local/lib/libglib-2.0.so
> /usr/local/lib/libxml2.so -lz -lm /usr/lib/libpopt.so -Wl,--rpath
> -Wl,/usr/local/lib/gnopernicus-1.0 -Wl,--rpath -Wl,/usr/local/lib
> ../libbrl/.libs/libbrl.so: undefined reference to `errno'
> collect2: ld returned 1 exit status
> make[2]: *** [tester] Error 1
> make[2]: Leaving directory
> `/opt/gnopernicus_install_files/gnopernicus/braille/test'
> make[1]: *** [install-recursive] Error 1
> make[1]: Leaving directory
> `/opt/gnopernicus_install_files/gnopernicus/braille'
> make: *** [install-recursive] Error 1
>
>
> Please let me know if this is enough information.  Thanks for all the
> input.
>
>
>
>
>
>
>
>
>
> _________________________________________________________________
> STOP MORE SPAM with the new MSN 8 and get 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
> _______________________________________________
> gnome-accessibility-list mailing list
> gnome-accessibility-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-list

? intltool-extract
? intltool-extract.in
? intltool-merge
? intltool-merge.in
? intltool-update
? intltool-update.in
? libbrl.diff
? brlmon/braille_fonts/fonts.dir
? help/braille_monitor/C/omf_timestamp
? help/gnopernicus/C/omf_timestamp
? po/de.gmo
? po/gnopernicus0.pot
? po/ro.gmo
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gnopernicus/ChangeLog,v
retrieving revision 1.177
diff -u -p -r1.177 ChangeLog
--- ChangeLog	25 Feb 2003 10:56:55 -0000	1.177
+++ ChangeLog	25 Feb 2003 15:01:03 -0000
@@ -1,3 +1,11 @@
+2003-02-25 Adi Dascal <ad baum ro>
+
+	* braille/libbrl/sercomm.c:
+	Commented out extern int errno (this code should be reviewed, as in 
+	cleaned because there are too many comments)
+	(brl_ser_open_port): no need of errno.
+	
+
 2003-02-25 Pal Csongor Sprencz <ps baum ro>
 
 	* po/POTFILES.in:
Index: braille/libbrl/sercomm.c
===================================================================
RCS file: /cvs/gnome/gnopernicus/braille/libbrl/sercomm.c,v
retrieving revision 1.14
diff -u -p -r1.14 sercomm.c
--- braille/libbrl/sercomm.c	11 Nov 2002 19:15:44 -0000	1.14
+++ braille/libbrl/sercomm.c	25 Feb 2003 15:01:04 -0000
@@ -47,7 +47,11 @@ static BRL_SER_CALLBACK	ClientCallback =
 GIOChannel 		*gioch = NULL;						/* GLIB io channel */
 gboolean		glib_poll = TRUE;
 
-extern int 		errno;										/* thread error no */
+/*
+extern int 		errno;										
+*/
+/* thread error no */
+
 
 /* Functions */
 
@@ -69,7 +73,7 @@ int brl_ser_open_port (int Port)
 
 		default:
 			fprintf (stderr, "brl_open_port: Invalid serial port number %d\n", Port);
-			errno = -1;			
+/*			errno = -1;			*/
 			return 0;
 		break;
 	}