[g-a-devel] About where to place the implementation of atk_add_global_event_listener

[Piñeiro <apinheiro igalia com>]

Hi,

disclaimer: first try to forget the debate about global events vs
relevant evetns. As that debate doesn't have any conclusion, for the
moment we just have global events.

If you recall, one of the reasons to only allow to register to ATK
events on atk_add_global_event_listener[1], was the possibility to stop
to ask the toolkits to implement this method. After all this right now,
the implementation is basically a wrapper to g_signal_add_emission_hook,
so the implementation for Gtk and Clutter are basically the same.

At that moment the idea was about implementing this on ATK, providing a
default implementation for that method. But yesterday, while looking at
that (as part of trying to solve bug 678310) I start to wonder myself if
at this moment the proper place is ATK. What changed since then? That
now we have the bridge as a library, and possibly in the future,
toolkit/apps could ask for the bridge.

So I'm wondering if that hook should be implemented on the ATK bridge
instead of ATK itself. After all, the main consumer of that method is
the bridge, and can be implemented there. So, options:

Options a)
  * Implement it on Atk
  * Provide a default implementation for that AtkUtil virtual method,
discourage toolkits to reimplement that method on the documentation

Option b)
  * Implement it on at-spi2-atk
  * Deprecate AtkUtil->add_global_event_listener

What do you think?


[1]
http://developer.gnome.org/atk/stable/AtkUtil.html#atk-add-global-event-listener   

[2] https://bugzilla.gnome.org/show_bug.cgi?id=678310

-- 
Alejandro Piñeiro Iglesias