[g-a-devel]Patch for at-poke.



I have attached a patch to address bug 103473.

Review requested.

Padraig
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/at-poke/ChangeLog,v
retrieving revision 1.44
diff -u -p -r1.44 ChangeLog
--- ChangeLog	10 Dec 2002 15:47:06 -0000	1.44
+++ ChangeLog	15 Jan 2003 11:02:23 -0000
@@ -1,3 +1,14 @@
+2003-01-15  Padraig O'Briain   <padraig obriain sun com>
+
+	* src/poke.c (update_if_image): Prevent label for image
+	description from getting wider than 100.
+	This addresses bug #103463.
+
+	* glade/at-poke.glade2: 
+	Make MDI-Z_order aligned with other labels for Component.
+	Add border width for Image frame so that it is aligned with other
+	frames.
+
 2002-12-10  Padraig O'Briain   <padraig obriain sun com>
 
 	* src/accessible-tree-model.c:
Index: glade/at-poke.glade2
===================================================================
RCS file: /cvs/gnome/at-poke/glade/at-poke.glade2,v
retrieving revision 1.14
diff -u -p -r1.14 at-poke.glade2
--- glade/at-poke.glade2	16 Oct 2002 15:14:52 -0000	1.14
+++ glade/at-poke.glade2	15 Jan 2003 11:02:23 -0000
@@ -802,7 +802,7 @@
 			  <property name="justify">GTK_JUSTIFY_LEFT</property>
 			  <property name="wrap">False</property>
 			  <property name="selectable">False</property>
-			  <property name="xalign">0</property>
+			  <property name="xalign">1</property>
 			  <property name="yalign">0.5</property>
 			  <property name="xpad">2</property>
 			  <property name="ypad">0</property>
@@ -2057,6 +2057,7 @@
 
 	      <child>
 		<widget class="GtkFrame" id="poker_image_frame">
+		  <property name="border_width">1</property>
 		  <property name="visible">True</property>
 		  <property name="label_xalign">0</property>
 		  <property name="label_yalign">0.5</property>
Index: src/poke.c
===================================================================
RCS file: /cvs/gnome/at-poke/src/poke.c,v
retrieving revision 1.29
diff -u -p -r1.29 poke.c
--- src/poke.c	10 Dec 2002 15:47:07 -0000	1.29
+++ src/poke.c	15 Jan 2003 11:02:23 -0000
@@ -732,6 +732,7 @@ update_if_image (Poker *poker, Accessibl
 	long int w, h;
 
 	txt = AccessibleImage_getImageDescription (image);
+
 	gtk_label_set_text (GTK_LABEL (poker->image_descr),
 			    txt && txt [0] != '\0' ? txt : "<no description>");
 	SPI_freeString (txt);
@@ -1336,6 +1337,10 @@ poke (Accessible *accessible)
 	{ /* image interface */
 		poker->image_descr = glade_xml_get_widget (
 			poker->xml, "image_if_description");
+		/*
+		 * Prevent width of image description expanding too much.
+		 */
+                gtk_widget_set_size_request (poker->image_descr, 100, -1);
 		poker->image_size  = glade_xml_get_widget (
 			poker->xml, "image_if_size");
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]